Attachment 119753 Details for Bug 27282 – Bug 27282: fix all occurrences

[patch] Bug 27282: fix all occurrences

Bug-27282-fix-all-occurrences.patch (text/plain), 2.50 KB, created by Martin Renvoize (ashimema) on 2021-04-16 14:24:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-04-16 14:24:03 UTC

Size: 2.50 KB

patch

obsolete

>From 8b009195c53e8b21467f27b2785ed7f92ec9ffba Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 7 Jan 2021 15:57:16 +0000
>Subject: [PATCH] Bug 27282: fix all occurrences
>
>This patch fixes all the occurrences, staff and OPAC. The problem only happens on some versions of Chrome.
>TO TEST:
>-set up a new list with a few items
>-go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list.
>-Click 'Print List' in Chrome.
>-The tab opens but immediately closes itself.
>-Apply patch and clear cache
>-Try again, the print dialouge remains open
>
>-Go to cgi-bin/koha/sco/sco-main.pl in Chrome, make sure you can finish and print successfully
>-In the staff client in Chrome makes sure printing works in the following areas:
>    1. /cgi-bin/koha/circ/circulation.pl Print Slip and Print Quick Slip
>    2. /cgi-bin/koha/members/boraccount.pl Make a payment and make sure you can print the invoice
>    3. cgi-bin/koha/labels/spinelabel-home.pl Make a quick spine label in Chrome and make sure that prints.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc  | 5 ++++-
> koha-tmpl/opac-tmpl/bootstrap/en/includes/slip-print.inc | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc
>index d5e60ac8d9..fba67cffcf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/slip-print.inc
>@@ -6,7 +6,10 @@
> [% ELSE %]
>     $( window ).load(function() {
>         window.print();
>-        setTimeout('window.close()', 1);
>+        window.onafterprint = function () {
>+            window.close();
>+        }
>+        setTimeout('window.close()', 1000); //Hack from Chrome < 63
>     });
> [% END %]
> </script>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/slip-print.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/slip-print.inc
>index 63f4bc2897..51c1e0177d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/slip-print.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/slip-print.inc
>@@ -5,7 +5,10 @@
> [% ELSE %]
>     $( window ).load(function() {
>         window.print();
>-        setTimeout('window.close()', 1);
>+        window.onafterprint = function () {
>+            window.close();
>+        }
>+        setTimeout('window.close()', 1000); //Hack from Chrome < 63
>     });
> [% END %]
> </script>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27282: 114535 | 114562 | 114685 | 114933 | 119338 | 119339 | 119752 | 119753