Attachment 119758 Details for Bug 27896 – Bug 27896: Remove DeleteTransfer from circ/return.pl

[patch] Bug 27896: Remove DeleteTransfer from circ/return.pl

Bug-27896-Remove-DeleteTransfer-from-circreturnpl.patch (text/plain), 1.52 KB, created by Kyle M Hall (khall) on 2021-04-16 15:47:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-04-16 15:47:10 UTC

Size: 1.52 KB

patch

obsolete

>From 7cad20347d2a137725cb5c5e11c1fb6ca4fe747e Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 8 Mar 2021 15:24:14 +0000
>Subject: [PATCH] Bug 27896: Remove DeleteTransfer from circ/return.pl
>
>This patch replaces the DeleteTransfer call in circ/returns.pl with a
>call to Koha::Item::Transfer->cancel.
>
>Test plan
>1/ Check an item out
>2/ Add a transfer request for the item to a second library
>3/ Attempt to check the item in at the first library
>4/ Note that you should be given a 'WrongTransfer' modal and have to
>option to cancel.
>5/ Cancel the transfer
>6/ Check in the database that the transfer now has 'datecancelled' set.
>7/ Add a transfer for the item again
>8/ From the transferstoreceive page cancel the transfer
>9/ Click cancel and again check that datecancelled is set in the
>database for your transfer
>
>Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> circ/returns.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 5e2b0e26e4..d81cd35e24 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -228,7 +228,9 @@ if ($dotransfer){
> }
> 
> if ($canceltransfer){
>-    DeleteTransfer($itemnumber);
>+    my $item = Koha::Item->find($itemnumber);
>+    my $transfer = $item->get_transfer;
>+    $transfer->cancel({ reason => 'Manual', force => 1});
>     if($dest eq "ttr"){
>         print $query->redirect("/cgi-bin/koha/circ/transferstoreceive.pl");
>         exit;
>-- 
>2.24.3 (Apple Git-128)

Actions: View | Diff | Splinter Review

Attachments on bug 27896: 117927 | 117928 | 119345 | 119347 | 119348 | 119349 | 119758 | 119759 | 119760 | 119761