Attachment 119783 Details for Bug 28162 – Bug 28162: fix doubled scalar sigil

[patch] Bug 28162: fix doubled scalar sigil

Bug-28162-fix-doubled-scalar-sigil.patch (text/plain), 1.16 KB, created by Lucas Gass (lukeg) on 2021-04-16 19:52:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2021-04-16 19:52:58 UTC

Size: 1.16 KB

patch

obsolete

>From e92888f754b4e8e5ec967520cbc8dd850a1f3a35 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 16 Apr 2021 19:49:36 +0000
>Subject: [PATCH] Bug 28162: fix doubled scalar sigil
>
>TEST PLAN:
>
>1 Set up some patron extended attributes
>2 Make sure you check 'Display in OPAC' and 'Editable in OPAC'
>3 Go to self registration and attempt to register
>4 you get an error ( Not a SCALAR reference at /kohadevbox/koha/opac/opac-memberentry.pl line 110 )
>5 Apply patch
>6 repeat steps 1-3, ther should be no error now
>---
> opac/opac-memberentry.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
>index 015c56a3da..17f2b480f8 100755
>--- a/opac/opac-memberentry.pl
>+++ b/opac/opac-memberentry.pl
>@@ -107,7 +107,7 @@ my $conflicting_attribute = 0;
> 
> foreach my $attr (@$attributes) {
>     my $attribute = Koha::Patron::Attribute->new($attr);
>-    if ( !$$attribute->unique_ok ) {
>+    if ( !$attribute->unique_ok ) {
>         my $attr_type = Koha::Patron::Attribute::Types->find($attr->{code});
>         $template->param(
>             extended_unique_id_failed_code => $attr->{code},
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28162: 119782 | 119783 | 119803