Attachment 119817 Details for Bug 27432 – Bug 27432: Add report run to action logs

[patch] Bug 27432: Add report run to action logs

Bug-27432-Add-report-run-to-action-logs.patch (text/plain), 1.72 KB, created by Katrin Fischer on 2021-04-18 09:27:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-04-18 09:27:47 UTC

Size: 1.72 KB

patch

obsolete

>From 945dbc33f72d9176220ce6571f1ee7638d2ca5d2 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 14 Jan 2021 15:34:55 +0100
>Subject: [PATCH] Bug 27432: Add report run to action logs
>
>Reports run should be logged in action logs.
>
>This uses the exisiting action "Run" from cronjobs.
>Like for other actions, infos contains the report name ("Unknown report" is
>no report id provided) and executed SQL query.
>
>1) Apply patch
>2) Enable system preference "ReportsLog"
>3) Run a report
>4) Go to Tools > Log viewer
>5) Select module "Reports" and submit
>6) Check you see a log with report name and SQL query
>7) Change SQL of report, re-run
>8) Go to Tools > Log viewer
>9) Select module "Reports" and submit
>10) Select the 2 logs "Compare" and click "View comparison"
>
>Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/Reports/Guided.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm
>index 21627331dd..82eb4148d3 100644
>--- a/C4/Reports/Guided.pm
>+++ b/C4/Reports/Guided.pm
>@@ -542,6 +542,8 @@ sub execute_query {
>     my ( $sql, $offset, $limit, $sql_params, $report_id ) = @_;
> 
>     $sql_params = [] unless defined $sql_params;
>+    my $report = Koha::Reports->find($report_id) if $report_id;
>+    my $report_name = $report ? $report->report_name : 'Unknown report';
> 
>     # check parameters
>     unless ($sql) {
>@@ -594,6 +596,8 @@ sub execute_query {
>     };
>     warn $@ if $@;
> 
>+    logaction( "REPORTS", "Run", $report_id, "$report_name | $sql " ) if C4::Context->preference("ReportsLog");
>+
>     return ( $sth, { queryerr => $sth->errstr } ) if ($sth->err);
>     return ( $sth );
> }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27432: 115162 | 115184 | 115926 | 115927 | 117355 | 117356 | 117357 | 117358 | 118953 | 118954 | 118955 | 119817 | 119818 | 119819