Bugzilla – Attachment 119832 Details for
Bug 27631
Accessibility: Staff interface - `h1` on each page is Logo but should be page description/title
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27631: circ folder
Bug-27631-circ-folder.patch (text/plain), 10.99 KB, created by
Wainui Witika-Park
on 2021-04-19 05:37:11 UTC
(
hide
)
Description:
Bug 27631: circ folder
Filename:
MIME Type:
Creator:
Wainui Witika-Park
Created:
2021-04-19 05:37:11 UTC
Size:
10.99 KB
patch
obsolete
>From f59a5ac978a9f1e654e8420fb541a3f15f709021 Mon Sep 17 00:00:00 2001 >From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> >Date: Mon, 19 Apr 2021 05:35:46 +0000 >Subject: [PATCH] Bug 27631: circ folder > >Changed each of the pages in the circ folder to have one <h1> tag >showing that describes the page, rather than the <h1> describing the >logo. > >The hierarchy of heading tags may be broken in many pages, but this will >be dealt with in an additional bug. > >To test: >1) Go to the Staff Client >2) Apply patch >3) Go to each of the pages in the circ folder and check that they have >an obvious and descriptive heading >4) Ensure that the heading in the page is <h1> > >Sponsored-by: Catalyst IT >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 ++ > .../prog/en/modules/circ/circulation_batch_checkouts.tt | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt | 6 +++--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt | 4 +++- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt | 5 +++-- > 12 files changed, 23 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt >index ed01ed489d..fa61273d95 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/bookcount.tt >@@ -42,6 +42,8 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >+ <h1>Circulation statistics for [% title | html %]</h1> >+ > [% INCLUDE 'blocking_errors.inc' %] > <h2>[% title |html %] [% IF ( author ) %] by [% author |html %][% END %]</h2> > <h3>Barcode [% barcode | html %]</h3> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >index 5c100a9044..1a04e683b0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt >@@ -24,6 +24,8 @@ > > <div class="main container-fluid"> > >+ <h1>Circulation</h1> >+ > <div class="row"> > > <div class="col-sm-5 col-md-4"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 7fcde8578d..d3ee86ed67 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -59,6 +59,8 @@ > <div class="row"> > <div class="col-sm-10 col-sm-push-2"> > >+ <h1>Checkouts</h1> >+ > [% IF patron %] > [% INCLUDE 'members-toolbar.inc' %] > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt >index 967ee8495a..534f41ef0f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt >@@ -57,6 +57,7 @@ > <div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2"> > [% END %] > <main> >+ <h1>Batch check out</h1> > > [% IF patron %] > [% INCLUDE 'members-toolbar.inc' %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt >index f6b282bbc2..dbc2e89005 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt >@@ -38,6 +38,7 @@ > <div class="row"> > <div class="col-sm-10 col-sm-push-2"> > <main> >+ <h1>Offline circulation</h1> > > <audio id="alert_sound" src="[% interface | html %]/prog/sound/critical.ogg" preload="auto"></audio> > <audio id="success_sound" src="[% interface | html %]/prog/sound/beep.ogg" preload="auto"></audio> >@@ -51,7 +52,6 @@ > [% END %] > > <div id="offline-home" class="offline-home"> >- <h1>Offline circulation</h1> > <div class="row"> > <div class="col-sm-6"> > <ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >index 92d088b446..27f7fa6c5a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >@@ -40,7 +40,7 @@ > <main> > > [% IF ( noreport ) %] >- <h2>Overdue report</h2> >+ <h1>Overdue report</h1> > <p>Please choose one or more filters to proceed.</p> > [% ELSE %] > >@@ -108,7 +108,7 @@ > > [% ELSE %] > >- <h2>Overdue report</h2> >+ <h1>Overdue report</h1> > [% IF ( isfiltered ) %] > <p>There are no overdues matching your search. <a href="/cgi-bin/koha/circ/overdue.pl">Reset filter</a></p> > [% ELSE %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index b3c30b33dd..27cd04f4a6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -57,7 +57,7 @@ > </div> > [% END %] > >-<h2>Holds to pull placed between [% from | $KohaDates %] and [% to | $KohaDates %]</h2> >+<h1>Holds to pull placed between [% from | $KohaDates %] and [% to | $KohaDates %]</h1> > <h3>Reported on [% todaysdate | $KohaDates %]</h3> > <p>The following holds have not been filled. Please retrieve them and check them in.</p> > <div id="searchresults"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt >index 82b34fd02b..a39058fbe2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/renew.tt >@@ -44,7 +44,7 @@ > > [% IF error %] > <div class="dialog alert"> >- <h3>Cannot renew:</h3> >+ <h1>Cannot renew:</h1> > > [% IF error == "no_item" %] > >@@ -178,7 +178,7 @@ > > [% IF date_due %] > <div class="dialog message"> >- <h3>Item renewed:</h3> >+ <h1>Item renewed:</h1> > <p> > [% INCLUDE 'biblio-title.inc' biblio=item.biblio link = 1 %] > ( <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% item.itemnumber | uri %]&biblionumber=[% item.biblio.biblionumber | uri %]&bi=[% item.biblioitemnumber.biblioitemnumber | uri %]#item[% item.itemnumber | uri %]">[% item.barcode | html %]</a> ) >@@ -193,7 +193,7 @@ > <form method="post" action="/cgi-bin/koha/circ/renew.pl" autocomplete="off" > > > <fieldset> >- <h2>Renew</h2> >+ <h1>Renew</h1> > > [% IF Koha.Preference('UnseenRenewals') %] > <div class="renew_formfield"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >index d0973a1bbd..cfeef8e65e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >@@ -39,13 +39,15 @@ > </ol> > </nav> > >-[% INCLUDE 'blocking_errors.inc' %] > <div class="main container-fluid"> > <div class="row"> > <div class="col-sm-10 col-sm-push-2"> > <main> > > <h1>Request article from [% INCLUDE 'biblio-title.inc' link = 1 %]</h1> >+ >+[% INCLUDE 'blocking_errors.inc' %] >+ > [% IF no_patrons_found %] > <div class="dialog alert"> > <h3>Patron not found</h3> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 6c8eab60e0..24781bcf0d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -739,7 +739,7 @@ > <form id="checkin-form" method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off" > > <fieldset id="circ_returns_checkin"> > <div class="show_checkin_dialog" style="float:right;display:none"><button type="button" class="btn btn-default btn-sm" data-toggle="tooltip" title="Show the last checkin message"><i class="fa fa-info"></i></button></div> >- <h3>Check in</h3> >+ <h1>Check in</h1> > <div class="row"> > <div class="col-sm-6"> > <div class="hint">Enter item barcode:</div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt >index c6843c4ad9..c677948d0c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/set-library.tt >@@ -42,8 +42,10 @@ > > [% IF Koha.Preference('CircSidebar') %] > <div class="col-sm-10 col-sm-push-2"> >+ <h1>Set library</h1> > [% ELSE %] > <div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2"> >+ <h1>Set library</h1> > [% END %] > > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >index 6c44a5334f..4162ba7934 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >@@ -40,9 +40,10 @@ > <div class="col-sm-12"> > [% END %] > >- <h2>Holds awaiting pickup for your library on: [% show_date | $KohaDates %] >+ <h1>Holds awaiting pickup for your library on: [% show_date | $KohaDates %]</h1> >+ <h2> > [% IF ( all_branches_link ) %] >- <span style="margin-left:20px"><a href="[% all_branches_link | url %]"> >+ <span><a href="[% all_branches_link | url %]"> > View all libraries</a></span> > [% END %] > </h2> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27631
:
116352
|
119492
|
119493
|
119496
|
119497
|
119498
|
119500
|
119501
|
119502
|
119544
|
119545
|
119546
|
119547
|
119830
|
119831
|
119832
|
119834
|
119835
|
119836
|
119837
|
119838
|
119839
|
119840
|
119841
|
119842
|
119843
|
120158
|
120159
|
120160
|
120161
|
120162
|
120166
|
120190
|
120191
|
121356
|
121469
|
121470
|
121522
|
121559
|
125547
|
125548
|
125549
|
125550
|
125551
|
125552
|
125553
|
125554
|
125555
|
125556
|
125557
|
125558
|
125559
|
125560
|
125561
|
125562
|
125563
|
125564
|
127295
|
127296
|
127297
|
127298
|
127299
|
127300
|
127301
|
127302
|
127303
|
127304
|
127305
|
127306
|
127307
|
127308
|
127309
|
127310
|
127311
|
127312
|
127432
|
127433
|
127449
|
127456
|
131069
|
131070
|
131071
|
131072
|
131073
|
131074
|
131075
|
131076
|
131077
|
131078
|
131079
|
131080
|
131081
|
131082
|
131083
|
131084
|
131085
|
131086
|
131087
|
131192
|
132886
|
132887
|
132888
|
132889
|
132890
|
132891
|
132892
|
132893
|
132894
|
132895
|
132896
|
132897
|
132898
|
132899
|
132900
|
132901
|
132902
|
132903
|
132904
|
132905