Bugzilla – Attachment 119837 Details for
Bug 27631
Accessibility: Staff interface - `h1` on each page is Logo but should be page description/title
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders
Bug-27631-offlinecirc-patroncards-plugins-pos-rese.patch (text/plain), 14.32 KB, created by
Wainui Witika-Park
on 2021-04-19 07:51:16 UTC
(
hide
)
Description:
Bug 27631: offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders
Filename:
MIME Type:
Creator:
Wainui Witika-Park
Created:
2021-04-19 07:51:16 UTC
Size:
14.32 KB
patch
obsolete
>From 84f0b36dd35f32cd2029b3e1be4e2b50ba458454 Mon Sep 17 00:00:00 2001 >From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> >Date: Mon, 5 Apr 2021 09:30:06 +0000 >Subject: [PATCH] Bug 27631: offline_circ, patroncards, plugins, pos, reserve, > rotating_collections folders > >Changed each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders to have one <h1> tag showing that describes the page, rather than the <h1> describing the logo. > >The hierarchy of heading tags may be broken in many pages, but this will >be dealt with in an additional bug. > >To test: >1) Go to the Staff Client >2) Apply patch >3) Go to each of the pages in the offline_circ, patroncards, plugins, pos, reserve, rotating_collections folders and check that they have an obvious and descriptive heading >4) Ensure that the heading in the page is <h1> > >Sponsored-by: Catalyst IT >--- > koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt | 5 +++-- > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt | 3 +++ > koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 5 +++-- > .../intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt | 3 ++- > 15 files changed, 26 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt >index f329fcad64..dbd4e7a5f4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt >@@ -24,7 +24,7 @@ > <div class="row"> > <div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2"> > >- <h2>Koha offline circulation</h2> >+ <h1>Koha offline circulation</h1> > <p>Your file was uploaded. Once all files are uploaded, please process them in pending offline circulation actions.</p> > > [% FOREACH message IN messages %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt >index 2423b28cc5..1c6871f295 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt >@@ -30,7 +30,7 @@ > <div class="row"> > <div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2"> > >- <h2>Offline circulation</h2> >+ <h1>Offline circulation</h1> > > [% IF ( pending_operations ) %] > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt >index e302d2b1c1..77d8e053ba 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt >@@ -43,7 +43,7 @@ > <div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2"> > > [% IF ( transactions_loaded ) %] >- <h2>Koha offline circulation</h2> >+ <h1>Koha offline circulation</h1> > <p>Your data was processed. Here are the results:</p> > [% FOREACH message IN messages %] > [% IF ( message.message ) %] >@@ -58,7 +58,7 @@ > [% IF ( message.payment ) %]<p>Accepted payment ([% message.amount | html %]) from <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% message.borrowernumber | uri %]">[% message.firstname | html %] [% message.surname | html %]</a> ([% message.cardnumber | html %]): [% message.datetime | html %]</p>[% END %] > [% END %] > [% ELSE %] >- <h2>Upload offline circulation data</h2> >+ <h1>Upload offline circulation data</h1> > > <div id="fileuploadform"> > <form method="post" action="/cgi-bin/koha/offline_circ/process_koc.pl" enctype="multipart/form-data" class="validated"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >index 1a6f355a59..7a74ad94ee 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >@@ -45,6 +45,8 @@ > > [% INCLUDE 'patroncards-toolbar.inc' %] > >+ <h1>[% IF description %]Edit [% ELSIF batch_id %]Edit [% ELSE %]New [% END %]patron card batches</h1> >+ > [% IF ( duplicate_message ) %] > <div class="dialog message"> > <strong>Duplicate patrons removed from batch number [% batch_id | html %]: [% duplicate_count | html %]</strong> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >index 0a41e1b8b6..d821df71d1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >@@ -41,6 +41,8 @@ > > [% INCLUDE 'patroncards-toolbar.inc' %] > >+ <h1>[% IF ( layout_id ) %]Edit[% ELSE %]Create[% END %] patron card layout</h1> >+ > <!-- NOTE: The order of the elements on this form is crictical to correct processing. You've been warned... --> > <form name="input" action="/cgi-bin/koha/patroncards/edit-layout.pl" method="get"> > <div class="row"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt >index 4335b36832..1503e9f547 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt >@@ -41,7 +41,7 @@ > > [% INCLUDE 'patroncards-toolbar.inc' %] > >- <h3>[% IF (profile_id) %]Edit[% ELSE %]Create[% END%] printer profile[% IF (profile_id) %] ([% profile_id | html %])[% END %]</h3> >+ <h1>[% IF (profile_id) %]Edit[% ELSE %]Create[% END%] printer profile[% IF (profile_id) %] ([% profile_id | html %])[% END %]</h1> > <form name="input" action="/cgi-bin/koha/patroncards/edit-profile.pl" method="get"> > <fieldset class="rows"><legend>Profile settings</legend> > <ol> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt >index d2a61068cb..8e63d890b8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt >@@ -42,8 +42,8 @@ > <main> > > [% INCLUDE 'patroncards-toolbar.inc' %] >+ <h1>[% IF (template_id) %]Edit[% ELSE %]Create[% END %] patron card template[% IF (template_id) %] ([% template_id | html %])[% END %]</h1> > <form name="input" action="/cgi-bin/koha/patroncards/edit-template.pl" method="get"> >- <h3>[% IF (template_id) %]Edit[% ELSE %]Create[% END %] patron card template[% IF (template_id) %] ([% template_id | html %])[% END %]</h3> > <div class="row"> > <div class="col-sm-6"> > <fieldset class="rows"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt >index 061b14fcf6..3ea33eb72c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt >@@ -28,6 +28,7 @@ > > [% INCLUDE 'patroncards-toolbar.inc' %] > >+ <h1>Patron card creator</h1> > > </main> > </div> <!-- /.col-sm-10.col-sm-push-2 --> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt >index ae9e6e138b..a8beec4d09 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt >@@ -32,10 +32,11 @@ > <main> > > [% INCLUDE 'patroncards-toolbar.inc' %] >+ <h1>Image manager</h1> > [% INCLUDE 'patroncards-errors.inc' %] > <div class="row"> > <div class="col-sm-6"> >- <h1>Upload additional images for patron cards</h1> >+ <h2>Upload additional images for patron cards</h2> > <p>Manage additional images to use as logo, decoration or background on a patron card layout.</p> > <form name="upload_images" method="post" action="/cgi-bin/koha/patroncards/image-manage.pl" enctype="multipart/form-data"> > <fieldset class="brief"> >@@ -74,7 +75,7 @@ > </form> > </div> > <div class="col-sm-6"> >- <h1>Delete Images</h1> >+ <h2>Delete Images</h2> > [% IF ( TABLE ) %] > <form name="delete_images" method="post" action="/cgi-bin/koha/patroncards/image-manage.pl" enctype="multipart/form-data"> > <fieldset class="brief"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt >index a4c393e0b3..41fc63615e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt >@@ -56,6 +56,9 @@ > <main> > > [% INCLUDE 'patroncards-toolbar.inc' %] >+ >+ <h1>Patron card templates</h1> >+ > [% INCLUDE 'patroncards-errors.inc' %] > <div id="manage-patroncards-layouts"> > [% IF ( table_loop ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt >index 9d9e6b031f..07bc969110 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt >@@ -7,6 +7,7 @@ > > <body id="pcard_print" class="tools pcard"> > <div class="container-fluid"> >+ <h1>Patron card printing/exporting</h1> > [% IF ( batches ) %] > <form> > <h3>Click on the following link(s) to download the exported batch(es).</h3> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >index 33f50f5014..9a779c4f0e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt >@@ -31,6 +31,7 @@ > <div class="row"> > <div class="col-sm-10 col-sm-push-2"> > <main> >+ <h1>Plugins</h1> > > <div class="details"> > >@@ -67,7 +68,6 @@ > [% END %] > </div> > [% END %] >- <h1>Plugins</h1> > > [% IF search_results %] > <h2>Search results</h2> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt >index a7f35bfc64..7fa3fd4088 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt >@@ -33,6 +33,8 @@ > <div class="row"> > <div class="col-md-10 col-md-push-2"> > >+ <h1>Point of sale</h1> >+ > [% IF ( registers.size == 0 ) %] > <div id="error_message" class="dialog message"> > <p> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 963889cc68..8de544e15d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -70,6 +70,7 @@ > [% END %] > > <main> >+ <h1>Holds</h1> > > [% IF ( noitems ) %] > <div class="dialog alert"> >@@ -93,9 +94,9 @@ > [% END %] > > [% UNLESS ( multi_hold ) %] >- <h1>Place a hold on [% INCLUDE 'biblio-title.inc' link = 1 %]</h1> >+ <h2>Place a hold on [% INCLUDE 'biblio-title.inc' link = 2 %]</h2> > [% ELSE %] >- <h1>Confirm holds</h1> >+ <h2>Confirm holds</h2> > [% END %] > > [% UNLESS club OR patron OR patron.borrowernumber OR noitems %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt >index 7491f5ac8b..b0d4886025 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/addItems.tt >@@ -36,6 +36,7 @@ > <div class="row"> > <div class="col-sm-10 col-sm-push-2"> > <main> >+ <h1>Add/remove items from collection</h1> > > [% IF ( ! colId ) %] > <div class="dialog message"> >@@ -44,7 +45,7 @@ > </div> > [% ELSE %] > [% INCLUDE 'rotating-collections-toolbar.inc' %] >- <h1>Collection <em>[% colTitle | html %]</em></h1> >+ <h2>Collection <em>[% colTitle | html %]</em></h2> > > [% IF ( previousActionAdd ) %] > [% IF ( addSuccess ) %] >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=119837">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27631
:
116352
|
119492
|
119493
|
119496
|
119497
|
119498
|
119500
|
119501
|
119502
|
119544
|
119545
|
119546
|
119547
|
119830
|
119831
|
119832
|
119834
|
119835
|
119836
|
119837
|
119838
|
119839
|
119840
|
119841
|
119842
|
119843
|
120158
|
120159
|
120160
|
120161
|
120162
|
120166
|
120190
|
120191
|
121356
|
121469
|
121470
|
121522
|
121559
|
125547
|
125548
|
125549
|
125550
|
125551
|
125552
|
125553
|
125554
|
125555
|
125556
|
125557
|
125558
|
125559
|
125560
|
125561
|
125562
|
125563
|
125564
|
127295
|
127296
|
127297
|
127298
|
127299
|
127300
|
127301
|
127302
|
127303
|
127304
|
127305
|
127306
|
127307
|
127308
|
127309
|
127310
|
127311
|
127312
|
127432
|
127433
|
127449
|
127456
|
131069
|
131070
|
131071
|
131072
|
131073
|
131074
|
131075
|
131076
|
131077
|
131078
|
131079
|
131080
|
131081
|
131082
|
131083
|
131084
|
131085
|
131086
|
131087
|
131192
|
132886
|
132887
|
132888
|
132889
|
132890
|
132891
|
132892
|
132893
|
132894
|
132895
|
132896
|
132897
|
132898
|
132899
|
132900
|
132901
|
132902
|
132903
|
132904
|
132905