Bugzilla – Attachment 11984 Details for
Bug 8708
RSS feed for new comments is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8708 [Revised] RSS feed for new comments is broken
Bug-8708-Revised-RSS-feed-for-new-comments-is-brok.patch (text/plain), 1.55 KB, created by
Owen Leonard
on 2012-09-05 16:51:21 UTC
(
hide
)
Description:
Bug 8708 [Revised] RSS feed for new comments is broken
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2012-09-05 16:51:21 UTC
Size:
1.55 KB
patch
obsolete
>From b4b758641c60e93016ba921070518ab37d6ba2f7 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 31 Aug 2012 09:04:13 -0400 >Subject: [PATCH] Bug 8708 [Revised] RSS feed for new comments is broken >Content-Type: text/plain; charset="utf-8" > >Removing white space from the beginning of the file >so that XML processing will work correctly. > >Before the patch, viewing the page >(/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser >which supports RSS handling (ex: Firefox) will show you >unformatted and broken-looking text. After the patch the >page will trigger the browser's built-in RSS-handling format. > >Revision: Template now includes comment pointing out that the <xml> >declaration must not have any white space before it. >--- > .../prog/en/modules/opac-showreviews-rss.tt | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-showreviews-rss.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-showreviews-rss.tt >index 2159022..b354419 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-showreviews-rss.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-showreviews-rss.tt >@@ -1,6 +1,4 @@ >-[% USE KohaDates %] >- >-<?xml version="1.0" encoding="utf-8"?> >+[% USE KohaDates # XML declaration should have no white space before it %]<?xml version="1.0" encoding="utf-8"?> > <rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom"> > <channel> > <title><![CDATA[[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] Catalog Recent Comments]]></title> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8708
:
11911
|
11918
|
11984
|
11991