Bugzilla – Attachment 119866 Details for
Bug 24295
C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24295: Remove GetTransfers from C4/Search.pm
Bug-24295-Remove-GetTransfers-from-C4Searchpm.patch (text/plain), 1.79 KB, created by
Martin Renvoize (ashimema)
on 2021-04-19 15:20:41 UTC
(
hide
)
Description:
Bug 24295: Remove GetTransfers from C4/Search.pm
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-04-19 15:20:41 UTC
Size:
1.79 KB
patch
obsolete
>From d344937e2789a54c61721c4678122cdc1c6e5a31 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 19 Apr 2021 15:59:57 +0100 >Subject: [PATCH] Bug 24295: Remove GetTransfers from C4/Search.pm > >This patch removes the final use of GetTransfers from C4::Search. > >Test plan >1/ Perform a search that will include results for some items that have >transfers of various states assigned to them >2/ Check the results match expectations (before and after applying the >patch should look the same) >3/ Signoff >--- > C4/Search.pm | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index a4fafd1e01..8b0fe986f3 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1931,8 +1931,16 @@ sub searchResults { > # FIXME: to avoid having the query the database like this, and to make > # the in transit status count as unavailable for search limiting, > # should map transit status to record indexed in Zebra. >- # >- ($transfertwhen, $transfertfrom, $transfertto) = C4::Circulation::GetTransfers($item->{itemnumber}); >+ >+ my $item_object = Koha::Items->find($item->{itemnumber}); >+ my $transfer = defined($item_object) ? $item_object->get_transfer : undef; >+ ( $transfertwhen, $transfertfrom, $transfertto ) = >+ defined($transfer) >+ ? ( >+ $transfer->datesent, $transfer->frombranch, >+ $transfer->tobranch >+ ) >+ : ( '', '', '' ); > $reservestatus = C4::Reserves::GetReserveStatus( $item->{itemnumber} ); > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24295
:
118242
|
118243
|
118244
|
118245
|
118246
|
118247
|
118248
|
118249
|
118250
|
118287
|
118295
|
118296
|
118297
|
118298
|
118299
|
118300
|
118301
|
118302
|
118303
|
118304
|
118305
|
118306
|
118307
|
118308
|
118309
|
118310
|
119854
|
119855
|
119856
|
119857
|
119858
|
119859
|
119860
|
119861
|
119862
|
119863
|
119864
|
119866
|
119867
|
127465
|
127466
|
127467
|
127468
|
127469
|
127470
|
127471
|
127472
|
127473
|
127474
|
127475
|
127476
|
127477
|
130430
|
130431
|
130432
|
130433
|
130434
|
130435
|
130436
|
130437
|
130438
|
130439
|
130440
|
130441
|
130442
|
139546
|
139547
|
139548
|
139549
|
139550
|
139551
|
139552
|
139553
|
139554
|
139555
|
139556
|
139557
|
139558
|
139655
|
139656
|
139657
|
139658
|
139659
|
139660
|
139661
|
139662
|
139663
|
139664
|
139665
|
139666
|
139667