Bugzilla – Attachment 119908 Details for
Bug 28176
Transfer not created for items returning home if confirmed with "Yes, print slip" button
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28176: Transfer not created for items returning home if confirmed with "Yes, print slip" button
Bug-28176-Transfer-not-created-for-items-returning.patch (text/plain), 2.75 KB, created by
Kyle M Hall (khall)
on 2021-04-20 13:19:50 UTC
(
hide
)
Description:
Bug 28176: Transfer not created for items returning home if confirmed with "Yes, print slip" button
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-04-20 13:19:50 UTC
Size:
2.75 KB
patch
obsolete
>From 709c386e3deb76f2d8d6a134ce6ef6c52a4ce59b Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 20 Apr 2021 09:16:25 -0400 >Subject: [PATCH] Bug 28176: Transfer not created for items returning home if > confirmed with "Yes, print slip" button > >If an items is to be transferred home after being checked out at a different branch, the "Yes, print slip" button does not generate the transfer, but the "Yes" button does. > >Test Plan: > 1) Set AutomaticItemReturn to "Don't" > 2) Place a hold for pickup at a different branch > 3) Check in the item, confirm the hold and transfer > 4) Check in the item at the pickup branch > 5) Check the item out to the patron > 6) Check the item in at the pickup branch > 7) Confirm the transfer back to the home library with the "Yes, print > slip" button > 8) Check the branchtransfers table, not there is not open transfer > 9) Apply this patch, repeat steps 1-8 >10) Note the branch transfer was created! >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 6c8eab60e0..e8b8e18cc0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -594,7 +594,7 @@ > <div class="modal-footer"> > [% IF !transfer %] > <button type="submit" name="dotransfer" value="Yes" class="btn btn-default approve"><i class="fa fa-check"></i> Yes</button> >- <button type="button" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&&branchcode=[% returnbranch | uri %]&op=slip"><i class="fa fa-print"></i> Yes, print slip</button> >+ <button type="submit" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&&branchcode=[% returnbranch | uri %]&op=slip"><i class="fa fa-print"></i> Yes, print slip</button> > <button type="button" data-dismiss="modal" class="btn btn-default deny" name="notransfer" value="No"><i class="fa fa-times"></i> No</button> > [% ELSE %] > <button type="button" data-dismiss="modal" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button> >-- >2.24.3 (Apple Git-128)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28176
: 119908