Attachment 11991 Details for Bug 8708 – [SIGNED-OFF] Bug 8708 [Revised] RSS feed for new comments is broken

[patch] [SIGNED-OFF] Bug 8708 [Revised] RSS feed for new comments is broken

SIGNED-OFF-Bug-8708-Revised-RSS-feed-for-new-comme.patch (text/plain), 1.58 KB, created by Nicole C. Engard on 2012-09-05 19:54:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nicole C. Engard

Created: 2012-09-05 19:54:58 UTC

Size: 1.58 KB

patch

obsolete

>From 74d661cac49afe9fb67b16990529c91cf9b9298a Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 31 Aug 2012 09:04:13 -0400
>Subject: [PATCH] [SIGNED-OFF] Bug 8708 [Revised] RSS feed for new comments is broken
>
>Removing white space from the beginning of the file
>so that XML processing will work correctly.
>
>Before the patch, viewing the page
>(/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser
>which supports RSS handling (ex: Firefox)  will show you
>unformatted and broken-looking text. After the patch the
>page will trigger the browser's built-in RSS-handling format.
>
>Revision: Template now includes comment pointing out that the <xml>
>declaration must not have any white space before it.
>
>Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
>---
> .../prog/en/modules/opac-showreviews-rss.tt        |    4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-showreviews-rss.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-showreviews-rss.tt
>index 2159022..b354419 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-showreviews-rss.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-showreviews-rss.tt
>@@ -1,6 +1,4 @@
>-[% USE KohaDates %]
>-
>-<?xml version="1.0" encoding="utf-8"?>
>+[% USE KohaDates # XML declaration should have no white space before it %]<?xml version="1.0" encoding="utf-8"?>
> <rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">
> <channel>
>      <title><![CDATA[[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] Catalog Recent Comments]]></title>
>-- 
>1.7.2.3

Actions: View | Diff | Splinter Review

Attachments on bug 8708: 11911 | 11918 | 11984 | 11991