Attachment 119952 Details for Bug 27061 – Bug 27061: Remove duplicate permission check in svc/mana/search

[patch] Bug 27061: Remove duplicate permission check in svc/mana/search

Bug-27061-Remove-duplicate-permission-check-in-svc.patch (text/plain), 1.05 KB, created by Owen Leonard on 2021-04-21 13:56:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2021-04-21 13:56:33 UTC

Size: 1.05 KB

patch

obsolete

>From a178b8237fce79cd91cd26e6971d964edf2b6b4f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 20 Nov 2020 09:04:30 +0100
>Subject: [PATCH] Bug 27061: Remove duplicate permission check in
> svc/mana/search
>
>There is a call to check_cookie_auth then another one to get_template_and_user
>
>Test plan:
>Use mana to create new report and new subscription.
>Confirm that you need the necessary permissions to use it
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> svc/mana/search | 8 --------
> 1 file changed, 8 deletions(-)
>
>diff --git a/svc/mana/search b/svc/mana/search
>index 84b356c738..5b7b43f7a7 100755
>--- a/svc/mana/search
>+++ b/svc/mana/search
>@@ -29,14 +29,6 @@ use CGI;
> 
> my $input = CGI->new;
> 
>-my ( $auth_status, $sessionID ) =
>-  check_cookie_auth( $input->cookie('CGISESSID'),
>-    { serials => 'create_subscription' } );
>-
>-if ( $auth_status ne "ok" ) {
>-    exit 0;
>-}
>-
> my $templatename;
> if ($input->param( "resource" ) eq 'report') {
>     $templatename = "mana/mana-report-search-result.tt";
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27061: 113866 | 119952 | 120324