Bugzilla – Attachment 119957 Details for
Bug 23271
Koha::Patron::Category should use Koha::Object::Limit::Library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23271: Fix random failure from Categories.t
Bug-23271-Fix-random-failure-from-Categoriest.patch (text/plain), 1.72 KB, created by
Jonathan Druart
on 2021-04-21 15:26:04 UTC
(
hide
)
Description:
Bug 23271: Fix random failure from Categories.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-04-21 15:26:04 UTC
Size:
1.72 KB
patch
obsolete
>From d8342dd77fa7077d3c75df061f164e96677f4b45 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 21 Apr 2021 17:25:20 +0200 >Subject: [PATCH] Bug 23271: Fix random failure from Categories.t > > # Failed test 'The branch limitation should have been stored and retrieved' > # at t/db_dependent/Koha/Patron/Categories.t line 57. > # Structures begin differing at: > # $got->[0] = 'fm0A1a' > # $expected->[0] = 'vNquBvCa' >--- > t/db_dependent/Koha/Patron/Categories.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Patron/Categories.t b/t/db_dependent/Koha/Patron/Categories.t >index 112c699066..906d897a87 100755 >--- a/t/db_dependent/Koha/Patron/Categories.t >+++ b/t/db_dependent/Koha/Patron/Categories.t >@@ -54,7 +54,7 @@ is( Koha::Patron::Categories->search->count, $nb_of_categories + 2, 'The 2 patro > > my $retrieved_category_1 = Koha::Patron::Categories->find( $new_category_1->categorycode ); > is( $retrieved_category_1->categorycode, $new_category_1->categorycode, 'Find a patron category by categorycode should return the correct category' ); >-is_deeply( [ $retrieved_category_1->library_limits->get_column('branchcode') ], [ $library_1->branchcode, $library_2->branchcode ], 'The branch limitation should have been stored and retrieved' ); >+is_deeply( [ sort $retrieved_category_1->library_limits->get_column('branchcode') ], [ sort $library_1->branchcode, $library_2->branchcode ], 'The branch limitation should have been stored and retrieved' ); > is_deeply( $retrieved_category_1->default_messaging, [], 'By default there is not messaging option' ); > > my $retrieved_category_2 = Koha::Patron::Categories->find( $new_category_2->categorycode ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23271
:
94292
|
94293
|
94294
|
119503
|
119504
|
119505
|
119529
|
119530
|
119531
|
119532
|
119533
|
119537
|
119579
|
119580
|
119581
|
119582
|
119583
|
119584
|
119772
|
119773
|
119774
|
119775
|
119776
|
119777
|
119939
|
119956
| 119957 |
120054