Attachment 119993 Details for Bug 28064 – Bug 28064: (QA follow-up) Remove value from button

[patch] Bug 28064: (QA follow-up) Remove value from button

Bug-28064-QA-follow-up-Remove-value-from-button.patch (text/plain), 2.11 KB, created by Martin Renvoize (ashimema) on 2021-04-22 10:46:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-04-22 10:46:02 UTC

Size: 2.11 KB

patch

obsolete

>From 614c8513f5acc40575057673639da780a313b253 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 22 Apr 2021 11:45:01 +0100
>Subject: [PATCH] Bug 28064: (QA follow-up) Remove value from button
>
>To clarify that the value is not used on buttons that are not submit
>type we remove the value entirely.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 0d621e1c72..8a4919d4d9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -598,7 +598,7 @@
>                                                 <div class="modal-footer">
>                                                     [% IF !transfer %]
>                                                         <button type="submit" name="dotransfer" value="Yes" class="btn btn-default approve"><i class="fa fa-check"></i> Yes</button>
>-                                                        <button type="button" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&amp;&amp;branchcode=[% returnbranch | uri %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button>
>+                                                        <button type="button" name="dotransfer" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&amp;&amp;branchcode=[% returnbranch | uri %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button>
>                                                         <button type="button" data-dismiss="modal" class="btn btn-default deny" name="notransfer" value="No"><i class="fa fa-times"></i> No</button>
>                                                     [% ELSE %]
>                                                         <button type="button" data-dismiss="modal" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28064: 119044 | 119045 | 119055 | 119056 | 119440 | 119441 | 119585 | 119993