Attachment 120000 Details for Bug 23207 – Bug 23207: Automatic checkin items should never be overdue

[patch] Bug 23207: Automatic checkin items should never be overdue

Bug-23207-Automatic-checkin-items-should-never-be-.patch (text/plain), 1.40 KB, created by Tomás Cohen Arazi (tcohen) on 2021-04-22 12:11:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-04-22 12:11:24 UTC

Size: 1.40 KB

patch

obsolete

>From 713cd3371a2f898fb5d6ef9da749bf5b23c00095 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 22 Apr 2021 09:03:01 -0300
>Subject: [PATCH] Bug 23207: Automatic checkin items should never be overdue
>
>This patch makes Koha::Checkouts->automatic_checkin pass the date_due as
>return date to AddReturn.
>
>To test:
>1. Apply the regression tests
>2. Run:
>   $ kshell
>  k$ prove t/db_dependent/Koha/Checkouts.t
>=> FAIL: The feature is not working properly
>3. Apply this patch
>4. Repeat 2
>=> SUCCESS: Tests pass!
>5. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Checkouts.pm | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Checkouts.pm b/Koha/Checkouts.pm
>index a7b50603d0c..0f2da95c651 100644
>--- a/Koha/Checkouts.pm
>+++ b/Koha/Checkouts.pm
>@@ -82,12 +82,12 @@ sub automatic_checkin {
>         { prefetch => 'item'}
>     );
> 
>-    while(my $checkout = $due_checkouts->next) {
>-        if($checkout->item->itemtype->automatic_checkin) {
>-            C4::Circulation::AddReturn($checkout->item->barcode, $checkout->branchcode);
>+    while ( my $checkout = $due_checkouts->next ) {
>+        if ( $checkout->item->itemtype->automatic_checkin ) {
>+            C4::Circulation::AddReturn( $checkout->item->barcode,
>+                $checkout->branchcode, undef, dt_from_string($checkout->date_due) );
>         }
>     }
>-
> }
> 
> =head3 type
>-- 
>2.31.1

Actions: View | Diff | Splinter Review

Attachments on bug 23207: 114212 | 114213 | 114214 | 114215 | 117970 | 117971 | 117972 | 117973 | 117984 | 117985 | 117986 | 117987 | 117991 | 117992 | 117993 | 117994 | 119726 | 119727 | 119728 | 119729 | 119730 | 119966 | 119967 | 119973 | 119985 | 119999 | 120000