Bugzilla – Attachment 120009 Details for
Bug 16787
'Too many holds' message appears inappropriately and is missing data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16787: (follow-up) Add and adjust ILSDI tests
Bug-16787-follow-up-Add-and-adjust-ILSDI-tests.patch (text/plain), 1.84 KB, created by
Nick Clemens (kidclamp)
on 2021-04-22 15:23:17 UTC
(
hide
)
Description:
Bug 16787: (follow-up) Add and adjust ILSDI tests
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-04-22 15:23:17 UTC
Size:
1.84 KB
patch
obsolete
>From 058f79aaba6b6c29dc1ce3802693c2194fc23e62 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 22 Apr 2021 15:22:49 +0000 >Subject: [PATCH] Bug 16787: (follow-up) Add and adjust ILSDI tests > >--- > t/db_dependent/ILSDI_Services.t | 22 ++++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t >index 37fd3fbdfb..c3be5cea94 100755 >--- a/t/db_dependent/ILSDI_Services.t >+++ b/t/db_dependent/ILSDI_Services.t >@@ -300,7 +300,7 @@ subtest 'LookupPatron test' => sub { > > subtest 'Holds test' => sub { > >- plan tests => 8; >+ plan tests => 9; > > $schema->storage->txn_begin; > >@@ -359,7 +359,7 @@ subtest 'Holds test' => sub { > itemtype => $item2->{itype}, > branchcode => $patron->{branchcode}, > rule_name => 'reservesallowed', >- rule_value => 0, >+ rule_value => 1, > } > ); > >@@ -371,6 +371,24 @@ subtest 'Holds test' => sub { > $reply = C4::ILSDI::Services::HoldItem( $query ); > is( $reply->{code}, 'tooManyReserves', "Too many reserves" ); > >+ Koha::CirculationRules->set_rule( >+ { >+ categorycode => $patron->{categorycode}, >+ itemtype => $item2->{itype}, >+ branchcode => $patron->{branchcode}, >+ rule_name => 'reservesallowed', >+ rule_value => 0, >+ } >+ ); >+ >+ $query = CGI->new; >+ $query->param( 'patron_id', $patron->{borrowernumber}); >+ $query->param( 'bib_id', $item2->biblionumber); >+ $query->param( 'item_id', $item2->itemnumber); >+ >+ $reply = C4::ILSDI::Services::HoldItem( $query ); >+ is( $reply->{code}, 'noReservesAllowed', "No reserves allowed" ); >+ > my $origin_branch = $builder->build( > { > source => 'Branch', >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16787
:
52652
|
68894
|
68895
|
72827
|
72828
|
72889
|
91146
|
91147
|
91148
|
91149
|
96152
|
97403
|
99949
|
99950
|
100951
|
101473
|
101474
|
101475
|
101895
|
107793
|
107794
|
107795
|
114675
|
114676
|
114677
|
119279
|
119280
|
119281
|
119335
|
119336
|
119337
|
119616
|
119617
|
119619
|
119620
|
119621
|
119622
|
119623
|
119738
|
119739
|
119740
|
119741
|
119942
| 120009