Bugzilla – Attachment 120031 Details for
Bug 27566
CSS rule not applying to HTML select / option - displays with serif font ignoring rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27566: (follow-up) Add generic font family to prevent unstyled select tags
Bug-27566-follow-up-Add-generic-font-family-to-pre.patch (text/plain), 2.74 KB, created by
Katrin Fischer
on 2021-04-22 21:46:17 UTC
(
hide
)
Description:
Bug 27566: (follow-up) Add generic font family to prevent unstyled select tags
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-04-22 21:46:17 UTC
Size:
2.74 KB
patch
obsolete
>From 7e648a74f78d3881f5c5ae58d77d76220ce0af43 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 7 Apr 2021 13:43:40 +0000 >Subject: [PATCH] Bug 27566: (follow-up) Add generic font family to prevent > unstyled select tags > >This correction fixes the previous patch which was dumb and stupid. > >This patch adds a default font family "sans-serif" to the OPAC CSS as a >workaround for this Firefox bug: > >font-family isn't honored in `<option>` element within `<select>` >dropdown >https://bugzilla.mozilla.org/show_bug.cgi?id=1536148 > >To test, apply the patch and rebuild the OPAC CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). > > - Open the OPAC main page in Firefox. > - Click the search type dropdown. The options should be styled using > your system's default sans-serif font rather than a serif font. > - Check that other areas of the OPAC are still styled with the correct > "NotoSans" font. An error with this patch should be obvious when > looking at a logged-in user's checkouts. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss | 2 +- > koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss >index 91d326a909..65e238d80b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss >@@ -1072,7 +1072,7 @@ button { > option, > select, > textarea { >- font-family: "NotoSans"; >+ font-family: "NotoSans", sans-serif; > } > } > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss >index 85d77fb352..b0ebcd45fa 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss >@@ -1,5 +1,5 @@ > @font-face { >- font-family: "NotoSans, sans-serif"; >+ font-family: "NotoSans"; > font-style: normal; > font-weight: 400; > src: local("Noto Sans Regular"), >@@ -8,7 +8,7 @@ > } > > @font-face { >- font-family: "NotoSans, sans-serif"; >+ font-family: "NotoSans"; > font-style: bold; > font-weight: 700; > src: local("Noto Sans Bold"), >@@ -17,7 +17,7 @@ > } > > @font-face { >- font-family: "NotoSans, sans-serif"; >+ font-family: "NotoSans"; > font-style: italic; > font-weight: 400; > src: local("Noto Sans Italic"), >@@ -26,7 +26,7 @@ > } > > @font-face { >- font-family: "NotoSans, sans-serif"; >+ font-family: "NotoSans"; > font-style: italic; > font-weight: 700; > src: local("Noto Sans Bold Italic"), >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27566
:
115975
|
118369
|
118568
|
118591
|
119322
|
119560
| 120031