Attachment 120116 Details for Bug 24446 – Bug 24446: (follow-up) Fix tests

[patch] Bug 24446: (follow-up) Fix tests

Bug-24446-follow-up-Fix-tests.patch (text/plain), 1.59 KB, created by Nick Clemens (kidclamp) on 2021-04-23 15:23:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-04-23 15:23:49 UTC

Size: 1.59 KB

patch

obsolete

>From ef279d4373bb1de6c16c95e818a87cfef1567747 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 23 Apr 2021 15:22:44 +0000
>Subject: [PATCH] Bug 24446: (follow-up) Fix tests
>
>The tests were failing because we weren't actually changing the item, so store was doing nothing.
>
>We need to transfer 'from' a new branch so that the holdingbranch is changed
>---
> t/db_dependent/Koha/SearchEngine/Indexer.t | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Koha/SearchEngine/Indexer.t b/t/db_dependent/Koha/SearchEngine/Indexer.t
>index 3d8454c234..882b5b10f9 100755
>--- a/t/db_dependent/Koha/SearchEngine/Indexer.t
>+++ b/t/db_dependent/Koha/SearchEngine/Indexer.t
>@@ -198,10 +198,10 @@ subtest 'Test indexer calls' => sub {
>         } undef, "index_records is not called for $engine when calling ModDateLastSeen if skip_record_index";
> 
>         warnings_are{
>-            ModItemTransfer( $item->itemnumber, $item->homebranch, $item2->homebranch,'Manual');
>+            ModItemTransfer( $item->itemnumber, $item2->homebranch, $item->homebranch,'Manual');
>         } [$engine,"Koha::Item"], "index_records is called for $engine when calling ModItemTransfer";
>         warnings_are{
>-            ModItemTransfer( $item->itemnumber, $item2->homebranch, $item->homebranch,'Manual',{skip_record_index=>1});
>+            ModItemTransfer( $item->itemnumber, $item->homebranch, $item2->homebranch,'Manual',{skip_record_index=>1});
>         } undef, "index_records is not called for $engine when calling ModItemTransfer with skip_record_index";
> 
>         warnings_are{
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24446: 105943 | 105944 | 105945 | 107246 | 107247 | 107248 | 107249 | 107250 | 107252 | 107253 | 107254 | 107255 | 107256 | 107301 | 107302 | 107303 | 107304 | 107305 | 110280 | 110281 | 110282 | 110283 | 110533 | 110534 | 110535 | 110536 | 110537 | 110538 | 110539 | 110540 | 110541 | 110542 | 111322 | 116557 | 116558 | 116559 | 116560 | 116561 | 116562 | 116563 | 116564 | 116565 | 116566 | 116567 | 116568 | 116569 | 116570 | 117589 | 117590 | 117591 | 117592 | 117593 | 117594 | 117595 | 117596 | 117597 | 117598 | 117599 | 117600 | 117601 | 117602 | 117603 | 117604 | 117605 | 117606 | 117607 | 120116