Bugzilla – Attachment 120122 Details for
Bug 26405
Circulation.t fails on 'AddRenewal left both fines'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26405: Prevent Circulation.t failing on 'AddRenewal left both fines'
Bug-26405-Prevent-Circulationt-failing-on-AddRenew.patch (text/plain), 1.46 KB, created by
Kyle M Hall (khall)
on 2021-04-23 16:18:17 UTC
(
hide
)
Description:
Bug 26405: Prevent Circulation.t failing on 'AddRenewal left both fines'
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-04-23 16:18:17 UTC
Size:
1.46 KB
patch
obsolete
>From ed186e168e1a21fc6e41ee4a66612e9a079e698d Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@outlook.com> >Date: Thu, 3 Dec 2020 10:41:47 +0200 >Subject: [PATCH] Bug 26405: Prevent Circulation.t failing on 'AddRenewal left > both fines' > >Bug 23051 added option to skip calculating fines even when >"CalculateFinesOnReturn" is enabled. Due this Circulation.t >fails on test "AddRenewal left both fines" if >"CalculateFinesOnReturn" is disabled on ones system. >Mocking syspref while testing fixes failig tests. > >To test: >1. Disable "CalculateFinesOnReturn". >2. Run prove t/db_dependent/Circulation.t >=> Tests fail >3. Apply patch. >4. Run prove t/db_dependent/Circulation.t again >=> Tests are succesful > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > t/db_dependent/Circulation.t | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index f95002efa0..6266d14561 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -705,6 +705,9 @@ subtest "CanBookBeRenewed tests" => sub { > } > ); > >+ # Make sure fine calculation isn't skipped when adding renewal >+ t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1); >+ > t::lib::Mocks::mock_preference('RenewalLog', 0); > my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } ); > my %params_renewal = ( >-- >2.24.3 (Apple Git-128)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26405
:
114135
|
118342
| 120122