Attachment 120170 Details for Bug 27864 – Bug 27864: (QA follow-up) Remove size=1 on selects (28066 follow-up)

[patch] Bug 27864: (QA follow-up) Remove size=1 on selects (28066 follow-up)

Bug-27864-QA-follow-up-Remove-size1-on-selects-280.patch (text/plain), 1.90 KB, created by Tomás Cohen Arazi (tcohen) on 2021-04-26 11:22:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-04-26 11:22:40 UTC

Size: 1.90 KB

patch

obsolete

>From 3dffbf4f9042728acbcb3c154d2c5eafabd44267 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 26 Apr 2021 08:21:41 -0300
>Subject: [PATCH] Bug 27864: (QA follow-up) Remove size=1 on selects (28066
> follow-up)
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index a98d4d4fda3..3da7d3004b4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -442,10 +442,10 @@
>                             <li>
>                                 <label for="pickup">Pickup at:</label>
>                             [% UNLESS ( multi_hold ) %]
>-                                <select name="pickup" size="1" id="pickup" data-biblio-id="[% biblio.biblionumber | html %]" data-patron-id="[% patron.borrowernumber | html %]">
>+                                <select name="pickup" id="pickup" data-biblio-id="[% biblio.biblionumber | html %]" data-patron-id="[% patron.borrowernumber | html %]">
>                                     <option selected="selected" value="[% pickup | html %]">[% Branches.GetName(pickup) | html %]</option>
>                             [% ELSE %]
>-                                <select name="pickup" size="1" id="pickup" data-patron-id="[% patron.borrowernumber | html %]">
>+                                <select name="pickup" id="pickup" data-patron-id="[% patron.borrowernumber | html %]">
>                                     [% PROCESS options_for_libraries libraries => Branches.all({ selected => pickup, search_params => { pickup_location => 1 } }) %]
>                             [% END %]
>                                 </select>
>-- 
>2.31.1

Actions: View | Diff | Splinter Review

Attachments on bug 27864: 118232 | 118236 | 119722 | 119723 | 120012 | 120013 | 120014 | 120015 | 120170 | 120243 | 120244 | 120245 | 120341 | 120342