Attachment 120174 Details for Bug 28221 – Bug 28221: Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it

[patch] Bug 28221: Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it

Bug-28221-Script-processmessagequeuepl-uses-TryTin.patch (text/plain), 1.33 KB, created by Martin Renvoize (ashimema) on 2021-04-26 14:05:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-04-26 14:05:15 UTC

Size: 1.33 KB

patch

obsolete

>From 72e3aa6efad09edcd87a76d407e3cde219870481 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 26 Apr 2021 06:30:17 -0400
>Subject: [PATCH] Bug 28221: Script process_message_queue.pl uses Try::Tiny but
> doesn't 'use' it
>
>The message queue processor has a try/catch block, but does not have a 'use Try::Tiny' line. Because of this the following error ocurrs if an instance has any plugins installed that use the before_send_messages hook:
>
>Can't locate object method "catch" via package "1" (perhaps you forgot to load "1"?) at /usr/share/koha/bin/cronjobs/process_message_queue.pl line 86.
>
>Test Plan:
>1) Install a plugin that uses the before_send_messages hook
>2) Run the message queue processor
>3) Note the error message
>4) Apply this patch
>5) Run the message queue processor again
>6) No error!
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> misc/cronjobs/process_message_queue.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/misc/cronjobs/process_message_queue.pl b/misc/cronjobs/process_message_queue.pl
>index 664936753f..a903f1e06d 100755
>--- a/misc/cronjobs/process_message_queue.pl
>+++ b/misc/cronjobs/process_message_queue.pl
>@@ -30,6 +30,7 @@ use Koha::Script -cron;
> use C4::Letters;
> use C4::Log;
> use Getopt::Long;
>+use Try::Tiny;
> 
> my $username = undef;
> my $password = undef;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28221: 120169 | 120174