Bugzilla – Attachment 120176 Details for
Bug 28228
Warns from plugins when metadata value not defined for key
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28228: Supress plugin related error message
Bug-28228-Supress-plugin-related-error-message.patch (text/plain), 1.09 KB, created by
Kyle M Hall (khall)
on 2021-04-26 14:40:41 UTC
(
hide
)
Description:
Bug 28228: Supress plugin related error message
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-04-26 14:40:41 UTC
Size:
1.09 KB
patch
obsolete
>From 7f4006267640cb7245803c31512116f5d7ba23b2 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 30 Jun 2020 12:20:39 -0400 >Subject: [PATCH] Bug 28228: Supress plugin related error message > >Use of uninitialized value in subroutine entry at /usr/share/koha/lib/Koha/Plugins/Base.pm line 182. > >Test Plan: >1) Install the Kitchen Sink plugin ( it does not have a max versio defined ) >2) Note the warning in your logs >3) Apply this patch >4) Restart all the things >5) No warning! >--- > Koha/Plugins/Base.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Plugins/Base.pm b/Koha/Plugins/Base.pm >index a5cb15e3c1..d6323e830e 100644 >--- a/Koha/Plugins/Base.pm >+++ b/Koha/Plugins/Base.pm >@@ -179,7 +179,7 @@ sub get_metadata { > > #FIXME: Why another encoding issue? For metadata containing non latin characters. > my $metadata = $self->{metadata}; >- $metadata->{$_} && utf8::decode($metadata->{$_}) for keys %$metadata; >+ defined($metadata->{$_}) && utf8::decode($metadata->{$_}) for keys %$metadata; > return $metadata; > } > >-- >2.24.3 (Apple Git-128)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28228
:
120176
|
124789
|
124795