Bugzilla – Attachment 120180 Details for
Bug 28210
C4::Circulation::LostItem should pass through skip_record_index to MarkIssueReturned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28210: Add issue, replacementprice, and set onloan so check-in tests work
Bug-28210-Add-issue-replacementprice-and-set-onloa.patch (text/plain), 2.97 KB, created by
Nick Clemens (kidclamp)
on 2021-04-26 15:58:37 UTC
(
hide
)
Description:
Bug 28210: Add issue, replacementprice, and set onloan so check-in tests work
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-04-26 15:58:37 UTC
Size:
2.97 KB
patch
obsolete
>From 2184c3425e5ff3f78bf0dd6a164dfd3c3e41f67a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 26 Apr 2021 15:57:09 +0000 >Subject: [PATCH] Bug 28210: Add issue, replacementprice, and set onloan so > check-in tests work > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Koha/SearchEngine/Indexer.t | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Koha/SearchEngine/Indexer.t b/t/db_dependent/Koha/SearchEngine/Indexer.t >index 8eeb4dc120..a1740c7f71 100755 >--- a/t/db_dependent/Koha/SearchEngine/Indexer.t >+++ b/t/db_dependent/Koha/SearchEngine/Indexer.t >@@ -115,12 +115,14 @@ subtest 'Test indexer calls' => sub { > $item = $builder->build_sample_item({ > biblionumber => $biblio->biblionumber, > onloan => '2020-02-02', >- datelastseen => '2020-01-01' >+ datelastseen => '2020-01-01', >+ replacementprice => 0 > }); > $item2 = $builder->build_sample_item({ > biblionumber => $biblio->biblionumber, > onloan => '2020-12-12', >- datelastseen => '2020-11-11' >+ datelastseen => '2020-11-11', >+ replacementprice => 0 > }); > } [$engine,"Koha::Item",$engine,"Koha::Item"], "index_records is called for $engine when adding an item (Item->store)"; > warnings_are{ >@@ -158,15 +160,28 @@ subtest 'Test indexer calls' => sub { > warnings_are{ > AddReturn($item->barcode, $item->homebranch, 0, undef); > } [$engine,'C4::Circulation'], "index_records is called once for $engine when calling AddReturn if item not issued"; >+ $builder->build({ >+ source => 'Issue', >+ value => { >+ itemnumber => $item->itemnumber >+ } >+ }); >+ $item->onloan('2000-01-01')->store({ skip_record_index => 1 }); > warnings_are{ > LostItem( $item->itemnumber, "tests", 1); > } [$engine,"Koha::Item"], "index_records is called for $engine when calling LostItem with 'force_mark_returned'"; >+ $builder->build({ >+ source => 'Issue', >+ value => { >+ itemnumber => $item->itemnumber >+ } >+ }); >+ $item->onloan('2000-01-01')->store({ skip_record_index => 1 }); > warnings_are{ > LostItem( $item->itemnumber, "tests", 1, { skip_record_index => 1 }); > } undef, "index_records is not called for $engine when calling LostItem with 'force_mark_returned' if skip_record_index"; > >- $item->datelastseen('2020-02-02'); >- $item->store({skip_record_index=>1}); >+ $item->datelastseen('2001-01-01')->store({skip_record_index=>1}); > warnings_are{ > my $t1 = ModDateLastSeen( $item->itemnumber, 1, undef ); > } [$engine, "Koha::Item"], "index_records is called for $engine when calling ModDateLastSeen"; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28210
:
120118
|
120119
|
120179
| 120180 |
120181