Bugzilla – Attachment 120232 Details for
Bug 27819
Spurious errors when running delete_records_via_leader.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl
Bug-27819-Spurious-item-deletion-errors-from-delet.patch (text/plain), 3.10 KB, created by
Martin Renvoize (ashimema)
on 2021-04-27 13:54:28 UTC
(
hide
)
Description:
Bug 27819: Spurious item deletion errors from delete_records_via_leader.pl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-04-27 13:54:28 UTC
Size:
3.10 KB
patch
obsolete
>From 9eafc9140bf9a1ec0e54f7e2344e266260865a05 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Sat, 27 Feb 2021 17:24:56 +0000 >Subject: [PATCH] Bug 27819: Spurious item deletion errors from > delete_records_via_leader.pl > >The job reports errors when deleting items. > >The issue seems to be that Koha::Object->delete claims in the POD to >return -1, 0, or 1 as a result, but it in fact returns the Object >itself on a successful deletion > >The errors are reported as: >ERROR DELETING ITEM 501740: Koha::Item=HASH(0x55ce407a1a78) > >To recreate: > 1 - Find or create a record with some items > 2 - Ensure those items can be deleted (not on loan, etc.) > 3 - Edit the record leader and set position 5 to 'd' > 4 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm > 5 - Deletion succeeds, but reports failure on items > 6 - Apply patch > 7 - Find or create a new record as above, but this time add an > additional item and check it out to a patron > 8 - perl misc/cronjobs/delete_records_via_leader.pl -i -v > 9 - Test mode should report 1 item to be deleted, one with error >10 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm >11 - One item should be deleted, one item not, record not deleted >12 - check the item in >13 - perl misc/cronjobs/delete_records_via_leader.pl -i -v --confirm >14 - Successful deletion with no error reported > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > misc/cronjobs/delete_records_via_leader.pl | 26 +++++++++++++--------- > 1 file changed, 15 insertions(+), 11 deletions(-) > >diff --git a/misc/cronjobs/delete_records_via_leader.pl b/misc/cronjobs/delete_records_via_leader.pl >index c49b68111a..0287e43f57 100755 >--- a/misc/cronjobs/delete_records_via_leader.pl >+++ b/misc/cronjobs/delete_records_via_leader.pl >@@ -99,20 +99,24 @@ foreach my $m (@metadatas) { > foreach my $item ( @items ) { > my $itemnumber = $item->itemnumber; > >- my $error = $test ? "Test mode enabled" : $item->safe_delete; >- $error = undef if $error eq '1'; >- >- if ($error) { >- say "ERROR DELETING ITEM $itemnumber: $error"; >- } >- else { >- say "DELETED ITEM $itemnumber" if $verbose; >- $deleted_items_count++; >+ if( $test ){ >+ my $result = $item->safe_to_delete; >+ if ( $result eq "1") { >+ say "TEST MODE: Item $itemnumber would have been deleted"; >+ } else { >+ say "TEST MODE: ERROR DELETING ITEM $itemnumber: $result"; >+ } >+ } else { >+ my $result = $item->safe_delete; >+ if ( ref $result eq "Koha::Item" ){ >+ say "DELETED ITEM $itemnumber" if $verbose; >+ $deleted_items_count++; >+ } else { >+ say "ERROR DELETING ITEM $itemnumber: $result"; >+ } > } >- > $total_items_count++; > } >- > } > > my $error = $test ? q{Test mode enabled} : DelBiblio($biblionumber); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27819
:
117406
|
117407
|
119631
|
119632
| 120232 |
120233