Bugzilla – Attachment 120234 Details for
Bug 28148
JavaScript error when printing transfer slip for existing transfer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28148: Remove 'print' class from 'Print transfer slip' when transfer exists
Bug-28148-Remove-print-class-from-Print-transfer-s.patch (text/plain), 3.08 KB, created by
Martin Renvoize (ashimema)
on 2021-04-27 13:56:49 UTC
(
hide
)
Description:
Bug 28148: Remove 'print' class from 'Print transfer slip' when transfer exists
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-04-27 13:56:49 UTC
Size:
3.08 KB
patch
obsolete
>From 546d3552f0326a01e3a6c51e999a663e4c068319 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 14 Apr 2021 15:17:53 +0000 >Subject: [PATCH] Bug 28148: Remove 'print' class from 'Print transfer slip' > when transfer exists > >The 'print' class triggers JS to create the transfer and update a form > >When a transfer exists we have no form and use 'openWin' to trigger the >print > >Also, I remove a stray '1' in the template > >To test: >1 - Set AutomaticItemReturn to "Don't" >2 - Check in an item from another branch >3 - Confirm the transfer >4 - Check it in again >5 - Click 'Print slip' >6 - Note error in console: > Uncaught TypeError: this.form is null >7 - apply patch >8 - Repeat >9 - No error! > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 098cc90ec1..0fdb3fd6c6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -447,7 +447,7 @@ > <!-- CONFIRM --> > <button type="button" data-dismiss="modal" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button> > <!-- PRINT SLIP --> >- <button type="button" data-dismiss="modal" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&&branchcode=[% TransferWaitingAt | uri %]&op=slip"><i class="fa fa-print"></i> Print transfer slip</button> >+ <button type="button" data-dismiss="modal" class="btn btn-default openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&&branchcode=[% TransferWaitingAt | uri %]&op=slip"><i class="fa fa-print"></i> Print transfer slip</button> > <!-- CANCEL TRANSFER --> > <form method="post" action="returns.pl" name="mainform"> > <button class="btn btn-default deny" type="submit"><i class="fa fa-times"></i> Cancel transfer</button> >@@ -568,7 +568,7 @@ > <div id="item-transfer-modal" class="modal fade audio-alert-action block"> > [% ELSE %] > <div id="item-transfer-modal" class="modal fade audio-alert-action noblock"> >- [% END %]1 >+ [% END %] > <div class="modal-dialog"> > <div class="modal-content"> > <form method="post" action="returns.pl" name="mainform" id="mainform"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28148
:
119588
|
119589
|
119592
| 120234