Bugzilla – Attachment 120237 Details for
Bug 28202
Pickup libraries not sorted by name when placing hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28202: Pickup libraries must be sorted by name when placing hold
Bug-28202-Pickup-libraries-must-be-sorted-by-name-.patch (text/plain), 1.25 KB, created by
Martin Renvoize (ashimema)
on 2021-04-27 14:10:18 UTC
(
hide
)
Description:
Bug 28202: Pickup libraries must be sorted by name when placing hold
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-04-27 14:10:18 UTC
Size:
1.25 KB
patch
obsolete
>From 49ce9253a732d5487452fab2e70a93ecd0b4fa26 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Fri, 23 Apr 2021 11:10:15 +0200 >Subject: [PATCH] Bug 28202: Pickup libraries must be sorted by name when > placing hold > >When placing hold, the pickup libraries are not sorted by name but by code. > >You can see in other places : pickup_locations() calls >Koha::Libraries->search with { order_by => ['branchname'] } > >Test plan : >1) Go to staff interface >2) Create a new libary with code 'AAA' and name 'ZZZ'. >2) Select a record >3) Begin placing hold >4) Look at list in "Pickup at:" >=> Without patch library 'ZZZ' is first >=> With patch library 'ZZZ' is last > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Biblio.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm >index fc1affe233..1d84f01a7b 100644 >--- a/Koha/Biblio.pm >+++ b/Koha/Biblio.pm >@@ -226,7 +226,7 @@ sub pickup_locations { > } > > return Koha::Libraries->search( >- { branchcode => { '-in' => \@pickup_locations } } ); >+ { branchcode => { '-in' => \@pickup_locations } }, { order_by => ['branchname'] } ); > } > > =head3 hidden_in_opac >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28202
:
120039
|
120049
|
120050
|
120142
|
120143
|
120236
| 120237