Attachment 120263 Details for Bug 27636 – Bug 27636: Be explicit on the exception we expect

[patch] Bug 27636: Be explicit on the exception we expect

Bug-27636-Be-explicit-on-the-exception-we-expect.patch (text/plain), 1.12 KB, created by Kyle M Hall (khall) on 2021-04-28 10:29:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-04-28 10:29:12 UTC

Size: 1.12 KB

patch

obsolete

>From 4c352eb938ed284941df6a65190a87686534d887 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 28 Apr 2021 11:32:09 +0200
>Subject: [PATCH] Bug 27636: Be explicit on the exception we expect
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/Accounts.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t
>index 7480664a90..e9f23fef36 100755
>--- a/t/db_dependent/Accounts.t
>+++ b/t/db_dependent/Accounts.t
>@@ -205,7 +205,7 @@ subtest "Koha::Account::pay tests" => sub {
>     # We attempt to make a -$30 payment (a NEGATIVE payment)
>     $data = '-30.00';
>     $payment_note = '-$30.00 payment note';
>-    throws_ok { $account->pay( { amount => $data, note => $payment_note } ) } qr//, 'Croaked on call to pay with negative amount';
>+    throws_ok { $account->pay( { amount => $data, note => $payment_note } ) } 'Koha::Exceptions::Account::AmountNotPositive', 'Croaked on call to pay with negative amount';
> 
>     #We make a $150 payment ( > 1stLine )
>     $data = '150.00';
>-- 
>2.24.3 (Apple Git-128)

Actions: View | Diff | Splinter Review

Attachments on bug 27636: 116393 | 118471 | 118515 | 118516 | 118522 | 118523 | 119205 | 119206 | 119207 | 119242 | 119243 | 119244 | 120022 | 120023 | 120024 | 120089 | 120090 | 120091 | 120257 | 120258 | 120259 | 120262 | 120263 | 120270 | 120271 | 120272 | 120276 | 120294 | 120343 | 120344 | 120345