Attachment 120272 Details for Bug 27636 – Bug 27636: (QA follow-up) Restore AutoReconcile assumption

[patch] Bug 27636: (QA follow-up) Restore AutoReconcile assumption

Bug-27636-QA-follow-up-Restore-AutoReconcile-assum.patch (text/plain), 1.47 KB, created by Nick Clemens (kidclamp) on 2021-04-28 14:02:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-04-28 14:02:11 UTC

Size: 1.47 KB

patch

obsolete

>From cb9c9dbba7b633b963d0bbd8caaaa4dabc9f3943 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 28 Apr 2021 14:36:27 +0100
>Subject: [PATCH] Bug 27636: (QA follow-up) Restore AutoReconcile assumption
>
>This patch restores the behaviour of paycollect which relied on
>Koha::Account->pay ignoring the value of the AutoReconcile system
>preference.
>
>We now explicitly fall back to selecting all outstanding debit lines if
>a selection of lines is not passed into the controller.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> members/paycollect.pl | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/members/paycollect.pl b/members/paycollect.pl
>index 7fb55737e7..425a96c36e 100755
>--- a/members/paycollect.pl
>+++ b/members/paycollect.pl
>@@ -137,6 +137,8 @@ if ( $selected_accts ) {
>         }
>     );
>     $total_due = $sum->_resultset->first->get_column('total_amountoutstanding');
>+} else {
>+    @selected_accountlines = $account->outstanding_debits;
> }
> 
> if ( $total_paid and $total_paid ne '0.00' ) {
>@@ -207,6 +209,7 @@ if ( $total_paid and $total_paid ne '0.00' ) {
>                     {
>                         amount       => $total_paid,
>                         library_id   => $library_id,
>+                        lines        => \@selected_accountlines,
>                         note         => $note,
>                         payment_type => $payment_type,
>                         interface    => C4::Context->interface,
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27636: 116393 | 118471 | 118515 | 118516 | 118522 | 118523 | 119205 | 119206 | 119207 | 119242 | 119243 | 119244 | 120022 | 120023 | 120024 | 120089 | 120090 | 120091 | 120257 | 120258 | 120259 | 120262 | 120263 | 120270 | 120271 | 120272 | 120276 | 120294 | 120343 | 120344 | 120345