Bugzilla – Attachment 120349 Details for
Bug 28248
Exception when getting all orders
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28248: aqorders.created_by is nullable
Bug-28248-aqorderscreatedby-is-nullable.patch (text/plain), 1.46 KB, created by
Victor Grousset/tuxayo
on 2021-04-30 22:01:22 UTC
(
hide
)
Description:
Bug 28248: aqorders.created_by is nullable
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2021-04-30 22:01:22 UTC
Size:
1.46 KB
patch
obsolete
>From d0b26d41eb227983f49ff895e41842897493a3a0 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 29 Apr 2021 15:37:49 -0300 >Subject: [PATCH] Bug 28248: aqorders.created_by is nullable > >This patch introduces a change to the spec to acknowledge that the field >is nullable. This is fixed in 21.05+ as part of bug 20212. > >To test: >1. Have an order with created_by = NULL >2. Use your favourite REST tool (Advanced REST Client(libre), Postman?) to fetch the order >=> FAIL: It throws a nasty error about non-nullable field being null >3. Apply this patch >4. Reload all >5. Repeat 2 >=> SUCCESS: It returns things, created_by is NULL, as it should >6. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > api/v1/swagger/definitions/order.json | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/api/v1/swagger/definitions/order.json b/api/v1/swagger/definitions/order.json >index f3d07d3735..bbc1b24e33 100644 >--- a/api/v1/swagger/definitions/order.json >+++ b/api/v1/swagger/definitions/order.json >@@ -13,7 +13,10 @@ > "description": "Identifier for the linked bibliographic record" > }, > "created_by": { >- "type": "integer", >+ "type": [ >+ "integer", >+ "null" >+ ], > "description": "Interal patron identifier of the order line creator" > }, > "entry_date": { >-- >2.31.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28248
:
120318
|
120349
|
120675