Attachment 120434 Details for Bug 28135 – Bug 28135: Replace use of input type number in additem.js

[patch] Bug 28135: Replace use of input type number in additem.js

Bug-28135-Replace-use-of-input-type-number-in-addi.patch (text/plain), 2.46 KB, created by Martin Renvoize (ashimema) on 2021-05-04 10:35:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-05-04 10:35:59 UTC

Size: 2.46 KB

patch

obsolete

>From f78e9abb7ba312a0970f226a50ec2b73531cfe60 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 12 Apr 2021 11:25:35 +0000
>Subject: [PATCH] Bug 28135: Replace use of input type number in additem.js
>
>This patch corrects in instance where JavaScript is creating an input
>tag with type "number."
>
>To test, apply the patch and make sure the AcqCreateItem system
>preference is set to "when receiving."
>
>- Go to Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt
>  page -> Receive.
>- On the page for receiving items you should see an add item form.
>- Click the "Add multiple items" button at the bottom of the form.
>- Test the "Number of items to add" field. It should not accept any
>  input except numbers.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/additem.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/additem.js b/koha-tmpl/intranet-tmpl/prog/js/additem.js
>index 960ffc36dd..7d80ca8a77 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/additem.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/additem.js
>@@ -182,7 +182,7 @@ function cloneItemBlock(index, unique_item_fields, callback) {
>             buttonPlus += '<input type="button" class="addItemControl cancel" name="buttonClear" style="cursor:pointer;" onclick="clearItemBlock(this)" value="' + __("Clear") + '" />';
>             buttonPlus += '<input type="button" class="addItemControl" name="buttonPlusMulti" onclick="javascript:this.nextSibling.style.display=\'inline\'; return false;" style="cursor:pointer; margin:0 1em;" value="' + __("Add multiple items") + '" />';
>             buttonPlus += '<span id="add_multiple_copies" style="display:none">'
>-                +     '<input type="number" class="addItemControl" id="multiValue" name="multiValue" placeholder="' + __("Number of items to add") + '" />'
>+                +     '<input type="text" inputmode="numeric" pattern="[0-9]*" class="addItemControl" id="multiValue" name="multiValue" placeholder="' + __("Number of items to add") + '" />'
>                 +     '<input type="button" class="addItemControl" name=buttonAddMulti" style="cursor:pointer; margin:0 1em;" onclick="checkCount( this ,\'' + unique_item_fields + '\')" value="' + __("Add") + '" />'
>                 +     '<div class="dialog message">' + __("NOTE: Fields listed in the 'UniqueItemsFields' system preference will not be copied") + '</div>'
>                 + '</span>';
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28135: 119450 | 120434 | 120761