Attachment 120439 Details for Bug 27740 – Bug 27740: (QA follow-up) Fix 'Your purchase suggestions'

[patch] Bug 27740: (QA follow-up) Fix 'Your purchase suggestions'

Bug-27740-QA-follow-up-Fix-Your-purchase-suggestio.patch (text/plain), 2.76 KB, created by Martin Renvoize (ashimema) on 2021-05-04 10:58:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-05-04 10:58:27 UTC

Size: 2.76 KB

patch

obsolete

>From 4911eb4714028db5abcdc17f22a5c152dca38276 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 15 Apr 2021 15:38:16 +0100
>Subject: [PATCH] Bug 27740: (QA follow-up) Fix 'Your purchase suggestions'
>
>On the purchase suggestions page you could end up with two "Your
>purchase suggestions" headings, one as an h1 and one as an h2..
>
>Test plan
>1/ Add at least one purchage suggestion to a patron
>2/ Navigate to 'Purchase suggestions'
>3/ Note that just one 'Your purchase suggestsions' heading appears with
>a top level '1'.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../opac-tmpl/bootstrap/en/modules/opac-suggestions.tt      | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index 0086e7e40b..c9e824faef 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -41,8 +41,8 @@
>                 <div class="col-md-12 col-lg-10 order-1">
> 
>                     <div id="usersuggestions" class="maincontent">
>-                        <h1>Your purchase suggestions</h1>
>                         [% IF ( op_add ) %]
>+                            <h1>Your purchase suggestions</h1>
>                             [% IF ( Koha.Preference('MaxTotalSuggestions') != '' && patrons_total_suggestions_count >= Koha.Preference('MaxTotalSuggestions') ) %]
>                                     <h2 class="TooManySuggestions">You cannot place any more suggestions</h2>
>                                     <p class="TooManySuggestionsText">You may only add up to [% Koha.Preference('MaxTotalSuggestions') | html %] suggestions in [% Koha.Preference('NumberOfSuggestionDays') | html %] days.</p>
>@@ -261,7 +261,7 @@
>                         [% END #  IF op_add %]
> 
>                         [% IF ( op_else ) %]
>-                            <h2>
>+                            <h1>
>                                 [% IF Koha.Preference( 'OPACViewOthersSuggestions' ) == 1 %]
>                                     Purchase suggestions
>                                 [% ELSE %]
>@@ -271,7 +271,7 @@
>                                         Purchase suggestions
>                                     [% END %]
>                                 [% END %]
>-                            </h2>
>+                            </h1>
>                             [% FOR m IN messages %]
>                                 <div class="alert alert-[% m.type | html %]">
>                                     [% SWITCH m.code %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27740: 117629 | 117771 | 118837 | 118858 | 119633 | 119634 | 119635 | 119687 | 119688 | 119689 | 119690 | 119691 | 119815 | 119816 | 119953 | 119954 | 119955 | 119958 | 119981 | 120437 | 120438 | 120439 | 120440 | 120441 | 120442 | 120443