Attachment 120463 Details for Bug 28179 – Bug 28179: (follow-up) Remove console.log

[patch] Bug 28179: (follow-up) Remove console.log

Bug-28179-follow-up-Remove-consolelog.patch (text/plain), 1.64 KB, created by Jonathan Druart on 2021-05-04 13:35:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-05-04 13:35:10 UTC

Size: 1.64 KB

patch

obsolete

>From d269541e92b78fb9518543852b87f65eb8090eee Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 3 May 2021 18:08:49 +0000
>Subject: [PATCH] Bug 28179: (follow-up) Remove console.log
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This patch removes a "console.log" from detail.tt and replaces it with
>similar output to the user. It will probably never be triggered, but
>better to handle it gracefully than have a hidden log.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Rasmus LeiÃner <rasmus.leissner@solutions-factory.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index f48febbe01b..bde528c30d7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -1074,7 +1074,7 @@ Note that permanent location is a code, and location may be an authval.
>                             } else if ( div.attr("class") == "cover-image local-coverimg" ) {
>                                 lightbox_descriptions.push(_("Local cover image (<a href='%s'>edit</a>)").format($(img).data('link')));
>                             } else {
>-                                console.log("Source of the image cannot be guessed.")
>+                                lightbox_descriptions.push(_("Cover image source unknown"));
>                             }
>                         }
>                     }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28179: 119914 | 119915 | 119916 | 120108 | 120253 | 120254 | 120255 | 120256 | 120409 | 120410 | 120411 | 120412 | 120413 | 120459 | 120460 | 120461 | 120462 | 120463 | 120731 | 120732 | 120733 | 120734 | 120735