Attachment 120492 Details for Bug 14723 – Bug 14723: Use DATETIME instead DATE

[patch] Bug 14723: Use DATETIME instead DATE

Bug-14723-Use-DATETIME-instead-DATE.patch (text/plain), 1.28 KB, created by Kyle M Hall (khall) on 2021-05-05 11:38:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-05-05 11:38:13 UTC

Size: 1.28 KB

patch

obsolete

>From a055d5f59cbf0b8879fcb8057b9f1f888c7f4d17 Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Mon, 3 May 2021 10:37:02 +0300
>Subject: [PATCH] Bug 14723: Use DATETIME instead DATE
>
>Letters.t tests failed since time_queued didn't
>include timecode. Use DATETIME when inserting
>into message_queue.
>
>To test prove t/db_dependent/Letters.t
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Letters.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index c80b328f1d..d0e50982b6 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -965,7 +965,7 @@ sub EnqueueLetter {
> INSERT INTO message_queue
> ( borrowernumber, subject, content, metadata, letter_code, message_transport_type, status, time_queued, to_address, from_address, reply_address, content_type, delivery_note )
> VALUES
>-( ?,              ?,       ?,       ?,        ?,           ?,                      ?,      CAST(NOW() AS DATE),       ?,          ?,            ?,           ?,              ? )
>+( ?,              ?,       ?,       ?,        ?,           ?,                      ?,      CAST(NOW() AS DATETIME),       ?,          ?,            ?,           ?,              ? )
> ENDSQL
> 
>     my $sth    = $dbh->prepare($statement);
>-- 
>2.24.3 (Apple Git-128)

Actions: View | Diff | Splinter Review

Attachments on bug 14723: 42053 | 42074 | 42159 | 42170 | 42227 | 42228 | 42384 | 42453 | 42455 | 42466 | 42505 | 42553 | 42574 | 42668 | 42669 | 44367 | 44413 | 62080 | 62138 | 78313 | 87525 | 87531 | 105776 | 105777 | 116642 | 116643 | 118225 | 120252 | 120309 | 120310 | 120312 | 120314 | 120376 | 120487 | 120488 | 120489 | 120490 | 120491 | 120492 | 120667