Bugzilla – Attachment 120632 Details for
Bug 24434
C4::Circulation::updateWrongTransfer is never called but should be
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24434: Add 'WrongTransfer' to cancellation_reasons
Bug-24434-Add-WrongTransfer-to-cancellationreasons.patch (text/plain), 3.04 KB, created by
Martin Renvoize (ashimema)
on 2021-05-06 13:17:33 UTC
(
hide
)
Description:
Bug 24434: Add 'WrongTransfer' to cancellation_reasons
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-05-06 13:17:33 UTC
Size:
3.04 KB
patch
obsolete
>From 962356e53a2043c23b785f156a49b51d654ef313 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 6 May 2021 14:14:24 +0100 >Subject: [PATCH] Bug 24434: Add 'WrongTransfer' to cancellation_reasons > >--- > .../data/mysql/atomicupdate/bug_24434.perl | 28 +++++++++++++++++++ > installer/data/mysql/kohastructure.sql | 2 +- > 2 files changed, 29 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_24434.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_24434.perl b/installer/data/mysql/atomicupdate/bug_24434.perl >new file mode 100644 >index 0000000000..8c99664ef5 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_24434.perl >@@ -0,0 +1,28 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ >+ # Add 'WrongTransfer' to branchtransfers cancellation_reason enum >+ $dbh->do( >+ q{ >+ ALTER TABLE >+ `branchtransfers` >+ MODIFY COLUMN >+ `cancellation_reason` enum( >+ 'Manual', >+ 'StockrotationAdvance', >+ 'StockrotationRepatriation', >+ 'ReturnToHome', >+ 'ReturnToHolding', >+ 'RotatingCollection', >+ 'Reserve', >+ 'LostReserve', >+ 'CancelReserve', >+ 'ItemLost', >+ 'WrongTransfer' >+ ) >+ AFTER `comments` >+ } >+ ); >+ >+ NewVersion( $DBversion, 24434, "Add 'WrongTransfer' to branchtransfers.cancellation_reason enum"); >+} >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index aa39f89043..ca967e5086 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1531,7 +1531,7 @@ CREATE TABLE `branchtransfers` ( > `tobranch` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '' COMMENT 'the branch the transfer was going to', > `comments` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'any comments related to the transfer', > `reason` enum('Manual','StockrotationAdvance','StockrotationRepatriation','ReturnToHome','ReturnToHolding','RotatingCollection','Reserve','LostReserve','CancelReserve', 'TransferCancellation') COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'what triggered the transfer', >- `cancellation_reason` ENUM('Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'ItemLost') default NULL COMMENT 'what triggered the transfer cancellation', >+ `cancellation_reason` ENUM('Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'ItemLost', 'WrongTransfer') default NULL COMMENT 'what triggered the transfer cancellation', > PRIMARY KEY (`branchtransfer_id`), > KEY `frombranch` (`frombranch`), > KEY `tobranch` (`tobranch`), >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24434
:
97449
|
97550
|
99829
|
120625
|
120631
|
120632
|
120657
|
120658
|
120683
|
120684
|
120757
|
120758
|
121029
|
121030
|
121031
|
121032
|
121033
|
121034
|
121057
|
121058
|
121059
|
121060
|
121061
|
121071
|
121072
|
121073
|
121074
|
121075
|
121515
|
121702
|
121703
|
121704
|
121705
|
121706
|
121707
|
121798
|
121799
|
121800
|
121801
|
121802
|
121803
|
121804