Attachment 120638 Details for Bug 24991 – Bug 24991: make koha-sip --restart start sip if it is not already running.

[patch] Bug 24991: make koha-sip --restart start sip if it is not already running.

Bug-24991-make-koha-sip---restart-start-sip-if-it-.patch (text/plain), 1.86 KB, created by Liz Rea on 2021-05-06 19:03:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2021-05-06 19:03:43 UTC

Size: 1.86 KB

patch

obsolete

>From 72f9fc89496589a336f78b7b3dc425e63c85dcce Mon Sep 17 00:00:00 2001
>From: Liz Rea <liz@bywatersolutions.com>
>Date: Thu, 6 May 2021 13:33:21 -0500
>Subject: [PATCH] Bug 24991: make koha-sip --restart start sip if it is not
> already running.
>
>To test:
>
>- make sure SIP is enabled
> sudo koha-sip --enable inst
>- make sure SIP is running
> sudo koha-sip --start inst
> sudo koha-sip --status inst
>- restart SIP, make sure it does this normally
> sudo koha-sip --restart inst
>- stop SIP, make sure it does this normally
> sudo koha-sip --stop inst
>- make sure SIP is not running (wild scenario: oomkiller or similar has killed this or some other thing has happened)
> sudo koha-sip --status inst
>- restart sip, make sure it starts SIP instead of silently failing
> sudo koha-sip --restart inst
>- check SIP is now running, or that there is an error message if it can't start
> sudo koha-sip --status inst
>---
> debian/scripts/koha-sip | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
>diff --git a/debian/scripts/koha-sip b/debian/scripts/koha-sip
>index 402e9fa2e3..97c326af11 100755
>--- a/debian/scripts/koha-sip
>+++ b/debian/scripts/koha-sip
>@@ -166,12 +166,20 @@ restart_sip()
>         done
>         echo $noLF `start_sip ${name}`
>     else
>-        if [ "$verbose" != "no" ]; then
>-            log_daemon_msg "Warning: SIP server not running for ${name}"
>-            log_end_msg 0
>-        else
>-            return 0
>+        echo $noLF `start_sip ${name}`
>+	if [ "$verbose" != "no" ]; then
>+            log_daemon_msg "Warning: SIP server not running for ${name}... trying to start"
>+	    log_end_msg 0
>         fi
>+	if is_sip_running ${name}; then
>+            return 0
>+	else
>+            if [ "$verbose" != "no" ]; then
>+	        log_daemon_msg "Warning: SIP server not started, check your config"
>+                log_end_msg 0
>+	    fi
>+    	    return 1
>+	fi
>     fi
> }
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 24991: 101874 | 120638 | 129807 | 130059 | 130060