Attachment 120677 Details for Bug 28181 – Bug 28181: Filter out archived debit types in point of sale

[patch] Bug 28181: Filter out archived debit types in point of sale

Bug-28181-Filter-out-archived-debit-types-in-point.patch (text/plain), 1.47 KB, created by PTFS Europe Sandboxes on 2021-05-07 11:20:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: PTFS Europe Sandboxes

Created: 2021-05-07 11:20:53 UTC

Size: 1.47 KB

patch

obsolete

>From d85fec1b20edc644cee38889c7103a4b60b58db1 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 22 Apr 2021 13:11:59 +0100
>Subject: [PATCH] Bug 28181: Filter out archived debit types in point of sale
>
>The filter for only displaying un-archived debit types on the point of
>sale page had been missed.
>
>NOTE: It would be beneficial to move this to a default filter in the
>Koha:: objects search method for both debit_types and credit_types.. but
>I opted for the quick fix here to resolve the bug and will impliment
>default filtering in a subsequent enhancement bug.
>
>Test plan
>1/ Archive a debit type that is marked as 'Can be sold'
>2/ Go to the point of sale page and confirm the above debit type appears
>3/ Apply the patch
>4/ Confirm the debit type no longer appears in the point of sale page.
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>---
> pos/pay.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/pos/pay.pl b/pos/pay.pl
>index e8bec0013d..c83405321e 100755
>--- a/pos/pay.pl
>+++ b/pos/pay.pl
>@@ -51,7 +51,8 @@ my $library_id         = C4::Context->userenv->{'branch'};
> my $registerid         = $input->param('registerid');
> 
> my $invoice_types =
>-  Koha::Account::DebitTypes->search_with_library_limits( { can_be_sold => 1 },
>+  Koha::Account::DebitTypes->search_with_library_limits(
>+    { can_be_sold => 1, archived => 0 },
>     {}, $library_id );
> $template->param( invoice_types => $invoice_types );
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28181: 120001 | 120677 | 120694