Attachment 120688 Details for Bug 27562 – Bug 27562: itiva notices break if record title contains quotes

[patch] Bug 27562: itiva notices break if record title contains quotes

Bug-27562-itiva-notices-break-if-record-title-cont.patch (text/plain), 1.79 KB, created by Owen Leonard on 2021-05-07 12:45:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2021-05-07 12:45:55 UTC

Size: 1.79 KB

patch

obsolete

>From 55ef586ae527d699210d4ec86497d668f2ade137 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 14 Jan 2013 09:02:38 -0800
>Subject: [PATCH] Bug 27562: itiva notices break if record title contains
> quotes
>
>itiva has reported to us that quotes in the title of a record cause the
>call to not be made to the patron. The fix is to remove quotes from
>the title, as quotes are not spoken anyway ( That is, "Queens" and
>"Queen's" are pronounced the same ).
>
>Test Plan:
>1) Set up itiva to send phone notes
>2) Find a record with quotes in the title
>3) Trigger an itiva notice ( checkout, checkin, place hold, etc )
>   using the itiva outbound cronjob
>4) View the CSV, note the title has the quotes in it
>5) Apply this patch
>6) Repeat steps 2-3
>7) View the CSV, note the title contains no quotes!
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
>index ae6a4f4e00..83b8a1a442 100755
>--- a/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
>+++ b/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
>@@ -160,6 +160,9 @@ foreach my $type (@types) {
>             );
>         }
> 
>+        $issues->{title} =~ s/'//g;
>+        $issues->{title} =~ s/"//g;
>+
>         print $OUT "\"$format\",\"$language\",\"$type\",\"$issues->{level}\",\"$issues->{cardnumber}\",\"$issues->{patron_title}\",\"$issues->{firstname}\",";
>         print $OUT "\"$issues->{surname}\",\"$issues->{phone}\",\"$issues->{email}\",\"$library_code\",";
>         print $OUT "\"$issues->{site}\",\"$issues->{site_name}\",\"$issues->{barcode}\",\"$due_date\",\"$issues->{title}\",\"$message_id\"\n";
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27562: 115909 | 120351 | 120688 | 120802