Bugzilla – Attachment 120723 Details for
Bug 28304
C4/Templates::new causes error logs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Bug-28304-quiet-a-warning-from-C4-Templates.patch (text/plain), 942 bytes, created by
Michael Hafen
on 2021-05-07 20:27:21 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Michael Hafen
Created:
2021-05-07 20:27:21 UTC
Size:
942 bytes
patch
obsolete
>From 8c92398d77e45ecd75c359d94962b27717f3d1aa Mon Sep 17 00:00:00 2001 >From: Michael Hafen <michael.hafen@washk12.org> >Date: Fri, 7 May 2021 14:25:11 -0600 >Subject: [PATCH] Bug 28304 - quiet a warning from C4/Templates >Content-Type: text/plain; charset="utf-8" > >Change the code in C4/Templates::new() which I presume initialized an >instance variable for caching. This call ends up calling a package method >instead. >--- > C4/Templates.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Templates.pm b/C4/Templates.pm >index 30ebaef9f8..3df60a2aa4 100644 >--- a/C4/Templates.pm >+++ b/C4/Templates.pm >@@ -82,7 +82,7 @@ sub new { > bless $self, $class; > $self->theme($theme); > $self->lang($lang); >- $self->activethemes($activethemes); >+ $self->{VARS}->{"activethemes"} = $activethemes; > $self->preferredtheme($activethemes->[0]); > $self->filename($filename); > $self->htdocs($htdocs); >-- >2.25.1 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=120723">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28304
:
120723
|
121113