Bugzilla – Attachment 120726 Details for
Bug 27942
QOTD: quote CSV uploads may contain JavaScript payloads (XSS)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27942: [20.11] Prevent XSS vulnerabilities in quote-upload
Bug-27942-2011-Prevent-XSS-vulnerabilities-in-quot.patch (text/plain), 3.07 KB, created by
Victor Grousset/tuxayo
on 2021-05-08 21:33:52 UTC
(
hide
)
Description:
Bug 27942: [20.11] Prevent XSS vulnerabilities in quote-upload
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2021-05-08 21:33:52 UTC
Size:
3.07 KB
patch
obsolete
>From e235d4857e5d8fdded88da10d7badd723a726c0b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 4 May 2021 11:48:03 +0200 >Subject: [PATCH] Bug 27942: [20.11] Prevent XSS vulnerabilities in > quote-upload > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > .../prog/en/modules/tools/quotes-upload.tt | 3 +++ > .../intranet-tmpl/prog/en/modules/tools/quotes.tt | 14 ++++++++++++-- > 2 files changed, 15 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt >index dc5da4b0f2..5b0dea1303 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt >@@ -148,6 +148,8 @@ > // then default to comma. > strDelimiter = (strDelimiter || ","); > >+ strData = escape_str(strData); >+ > // Create a regular expression to parse the CSV values. > var objPattern = new RegExp( > ( >@@ -274,6 +276,7 @@ > "fnDrawCallback": function(oSettings) { > /* Apply the jEditable handlers to the table on all fields w/o the no_edit id */ > $('#quotes_editor tbody td[id!="no_edit"]').editable( function(value, settings) { >+ value = escape_str(value); > var cellPosition = oTable.fnGetPosition( this ); > oTable.fnUpdate(value, cellPosition[0], cellPosition[1], false, false); > return(value); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt >index 6191b02037..ce94c8e33d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt >@@ -86,8 +86,18 @@ > "sAjaxSource" : "/cgi-bin/koha/tools/quotes/quotes_ajax.pl", > "aoColumns" : [ > { "sWidth": "3%" }, >- { "sWidth": "11%" }, >- { "sWidth": "75%" }, >+ { >+ "sWidth": "11%", >+ "render": function(data, type, row, meta){ >+ return escape_str(data); >+ } >+ }, >+ { >+ "sWidth": "75%", >+ "render": function(data, type, row, meta){ >+ return escape_str(data); >+ } >+ }, > { "sWidth": "11%" }, > ], > "oLanguage" : { >-- >2.31.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27942
:
118363
|
118867
|
119043
|
120429
|
120482
| 120726 |
120727