Bugzilla – Attachment 120736 Details for
Bug 28283
'Quantity received' should have inputmode="numeric"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive
Bug-28283-Add-inputmodenumeric-to-quantity-on-orde.patch (text/plain), 3.63 KB, created by
Katrin Fischer
on 2021-05-09 11:47:04 UTC
(
hide
)
Description:
Bug 28283: Add `inputmode="numeric"` to quantity on orderreceive
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-05-09 11:47:04 UTC
Size:
3.63 KB
patch
obsolete
>From 0aa16bbe5cde770eb86525b5c7f7194583fcf063 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 4 May 2021 11:14:51 +0100 >Subject: [PATCH] Bug 28283: Add `inputmode="numeric"` to quantity on > orderreceive > >This patch adds an inputmode to the quantity field on the order receive >page in acquisitions. > >Test plan >1. Go to Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt > page -> Receive. >2. Note that the 'Quantity received' input has an inputmode now. >3. Note that the 'Quantity received' input also has a pattern attribute. >4. Note that you should not be able to enter non-integer values. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index 3c89211676..f62b228052 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -309,25 +309,25 @@ > </span></li> > <li><label for="quantity">Quantity received: </label> > [% IF order.subscriptionid %] >- <input type="text" size="20" name="quantityrec" id="quantity" value="[% order.quantity | html %]" /> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" size="20" name="quantityrec" id="quantity" value="[% order.quantity | html %]" /> > <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="[% order.quantityreceived | html %]" /> > [% ELSIF AcqCreateItem == 'receiving' %] > <input readonly="readonly" type="text" size="20" name="quantityrec" id="quantity" value="0" /> > [% ELSE %] > [% IF ( order.quantityreceived ) %] > [% IF ( edit ) %] >- <input type="text" size="20" name="quantityrec" id="quantity" value="[% order.quantityreceived | html %]" /> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" size="20" name="quantityrec" id="quantity" value="[% order.quantityreceived | html %]" /> > <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="[% order.quantityreceived | html %]" /> > [% ELSE %] > [% IF ( order.items.count ) %] > <input readonly="readonly" type="text" size="20" name="quantityrec" id="quantity" value="[% order.quantityreceived + 1 | html %]" /> > [% ELSE %] >- <input type="text" size="20" name="quantityrec" id="quantity" value="[% quantityreceived + 1 | html %]" /> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" size="20" name="quantityrec" id="quantity" value="[% quantityreceived + 1 | html %]" /> > [% END %] > <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="[% order.quantityreceived | html %]" /> > [% END %] > [% ELSE %] >- <input type="text" id="quantity" size="20" name="quantityrec" value="1" /> >+ <input type="text" inputmode="numeric" pattern="[0-9]*" id="quantity" size="20" name="quantityrec" value="1" /> > <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="0" /> > [% END %] > <div id="qtyrecerror" style="display:none"> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28283
:
120430
|
120433
|
120687
| 120736