Bugzilla – Attachment 120746 Details for
Bug 26995
Drop column relationship from borrower tables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26995: (QA follow-up) Fix logic in database update
Bug-26995-QA-follow-up-Fix-logic-in-database-updat.patch (text/plain), 1.60 KB, created by
Katrin Fischer
on 2021-05-09 13:42:11 UTC
(
hide
)
Description:
Bug 26995: (QA follow-up) Fix logic in database update
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-05-09 13:42:11 UTC
Size:
1.60 KB
patch
obsolete
>From 39dcdb3b506a1a57be6b32948fb79a737f0d2462 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 4 May 2021 13:48:23 +0100 >Subject: [PATCH] Bug 26995: (QA follow-up) Fix logic in database update > >The logic was reversed.. if the column exists we want to delete it ;) > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > installer/data/mysql/atomicupdate/bug_26995.perl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_26995.perl b/installer/data/mysql/atomicupdate/bug_26995.perl >index d578c700bb..1a3ea15ea3 100644 >--- a/installer/data/mysql/atomicupdate/bug_26995.perl >+++ b/installer/data/mysql/atomicupdate/bug_26995.perl >@@ -1,18 +1,18 @@ > $DBversion = 'XXX'; # will be replaced by the RM > if( CheckVersion( $DBversion ) ) { >- if ( !column_exists( 'borrowers', 'relationship' ) ) { >+ if ( column_exists( 'borrowers', 'relationship' ) ) { > $dbh->do(q{ > ALTER TABLE borrowers DROP COLUMN relationship > }); > } > >- if ( !column_exists( 'deletedborrowers', 'relationship' ) ) { >+ if ( column_exists( 'deletedborrowers', 'relationship' ) ) { > $dbh->do(q{ > ALTER TABLE deletedborrowers DROP COLUMN relationship > }); > } > >- if ( !column_exists( 'borrower_modifications', 'relationship' ) ) { >+ if ( column_exists( 'borrower_modifications', 'relationship' ) ) { > $dbh->do(q{ > ALTER TABLE borrower_modifications DROP COLUMN relationship > }); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26995
:
115532
|
115533
|
115534
|
115537
|
115538
|
115539
|
120399
|
120400
|
120451
|
120452
|
120453
|
120744
|
120745
| 120746 |
120775
|
120793
|
120826