Attachment 120782 Details for Bug 28108 – Bug 28108: (QA follow-up) Move 'ORDER' back into 'ACQUITISIONS'

[patch] Bug 28108: (QA follow-up) Move 'ORDER' back into 'ACQUITISIONS'

Bug-28108-QA-follow-up-Move-ORDER-back-into-ACQUIT.patch (text/plain), 1.80 KB, created by Martin Renvoize (ashimema) on 2021-05-10 13:24:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-05-10 13:24:41 UTC

Size: 1.80 KB

patch

obsolete

>From 8b627cc537f5e1b1c9fb1df2c27ec5406cf1fedd Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 10 May 2021 14:21:46 +0100
>Subject: [PATCH] Bug 28108: (QA follow-up) Move 'ORDER' back into
> 'ACQUITISIONS'
>
>With the re-introduction of 'AQUISITIONS' as a logging module in Koha,
>it makes sence to move the ORDER notice logging back into that module
>whilst leaving the other 'CLAIMS' notices under their own logging module
>code.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Letters.pm                                    | 3 ++-
> installer/data/mysql/atomicupdate/claimslog.perl | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 03342f0428..99768ed656 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -534,8 +534,9 @@ sub SendAlerts {
>         return { error => $error }
>             unless $success;
> 
>+        my $module = $action eq 'ACQUISITION ORDER' ? 'ACQUISITIONS' : 'CLAIMS';
>         logaction(
>-            "CLAIMS",
>+            $module,
>             $action,
>             undef,
>             "To="
>diff --git a/installer/data/mysql/atomicupdate/claimslog.perl b/installer/data/mysql/atomicupdate/claimslog.perl
>index 8045b7d147..037339cbaf 100644
>--- a/installer/data/mysql/atomicupdate/claimslog.perl
>+++ b/installer/data/mysql/atomicupdate/claimslog.perl
>@@ -2,7 +2,7 @@ $DBversion = 'XXX';    # will be replaced by the RM
> if ( CheckVersion($DBversion) ) {
>     $dbh->do(q{
>         UPDATE action_logs SET module = 'CLAIMS'
>-        WHERE module = 'ACQUISITIONS' AND ( action = 'SERIAL CLAIM' OR action = 'ACQUISITION ORDER' OR action = 'ACQUISITION CLAIM')
>+        WHERE module = 'ACQUISITIONS' AND ( action = 'SERIAL CLAIM' OR action = 'ACQUISITION CLAIM')
>     });
> 
>     $dbh->do(q{
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28108: 119295 | 119548 | 120747 | 120748 | 120749 | 120763 | 120781 | 120782 | 120791