Bugzilla – Attachment 120800 Details for
Bug 28310
request.pl using biblioitemnumber in biblionumber field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28310: request.pl using biblioitemnumber in biblionumber field
Bug-28310-requestpl-using-biblioitemnumber-in-bibl.patch (text/plain), 1.38 KB, created by
Blou
on 2021-05-10 15:51:34 UTC
(
hide
)
Description:
Bug 28310: request.pl using biblioitemnumber in biblionumber field
Filename:
MIME Type:
Creator:
Blou
Created:
2021-05-10 15:51:34 UTC
Size:
1.38 KB
patch
obsolete
>From e36feb993f0ebb7747f49d263fd564dc129cf45c Mon Sep 17 00:00:00 2001 >From: Blou <blou@inlibro.com> >Date: Mon, 10 May 2021 11:42:48 -0400 >Subject: [PATCH] Bug 28310: request.pl using biblioitemnumber in biblionumber > field > >In reserve/request.pl, the code querying ItemsAnyAvailableAndNotRestricted (previously ItemsAnyAvailableForHold) >is passing the biblioitemnumber as a value to a specified biblionumber. > >>> ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron => $patron }) > >All you need is a Koha instance where the values of biblionumber and biblioitemnumber are not synchronized for this to break. And break badly. >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 9c83b617cf..e21838d85c 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -456,7 +456,7 @@ foreach my $biblionumber (@biblionumbers) { > # (before this loop was inside that sub loop so it was O(n^2) ) > my $items_any_available; > >- $items_any_available = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron => $patron }) >+ $items_any_available = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblionumber, patron => $patron }) > if $patron; > > foreach my $itemnumber ( @{ $itemnumbers_of_biblioitem{$biblioitemnumber} } ) { >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28310
: 120800