Attachment 12082 Details for Bug 8744 – Bug 8744: Thesaurus in authorities should not lock fields

[patch] Bug 8744: Thesaurus in authorities should not lock fields

Bug-8744-Thesaurus-in-authorities-should-not-lock-.patch (text/plain), 1.56 KB, created by Jared Camins-Esakov on 2012-09-09 12:55:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jared Camins-Esakov

Created: 2012-09-09 12:55:00 UTC

Size: 1.56 KB

patch

obsolete

>From f26c30850e052d2cfc63d2bbb0f6b4395204fe3f Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Sun, 9 Sep 2012 08:55:12 -0400
>Subject: [PATCH] Bug 8744: Thesaurus in authorities should not lock fields
>Content-Type: text/plain; charset="UTF-8"
>
>Although fields in the authority editor should support thesaurus
>control, they should never be locked, as authority records commonly
>refer to other records that may not be in use locally (and therefore
>might not be in the authority file).
>
>Test plan:
>1) Make sure a 5xx field in one of your authority frameworks is
>   thesaurus-controlled.
>2) Note that you cannot edit the field directly.
>3) Apply patch.
>4) Note that you can now edit the field directly.
>---
> authorities/authorities.pl |    5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/authorities/authorities.pl b/authorities/authorities.pl
>index 5b6afbd..661e465 100755
>--- a/authorities/authorities.pl
>+++ b/authorities/authorities.pl
>@@ -194,9 +194,8 @@ sub create_input {
>             id=\"".$subfield_data{id}."\"
>             name=\"".$subfield_data{id}."\"
>             value=\"$value\"
>-            class=\"input_marceditor readonly\"
>-            tabindex=\"1\"
>-            readonly=\"readonly\" \/>
>+            class=\"input_marceditor\"
>+            tabindex=\"1\" \/>
>         <a href=\"#\" class=\"buttonDot\"
>         onclick=\"openAuth(this.parentNode.getElementsByTagName('input')[1].id,'".$tagslib->{$tag}->{$subfield}->{authtypecode}."'); return false;\" tabindex=\"1\" title=\"Tag Editor\">...</a>
>     ";
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8744: 12082 | 12087 | 12088