Bugzilla – Attachment 120831 Details for
Bug 27885
Populate biblionumbers parameter when placing hold on single title
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27885: Populate biblionumbers parameter using biblionumbers array
Bug-27885-Populate-biblionumbers-parameter-using-b.patch (text/plain), 1.83 KB, created by
Nick Clemens (kidclamp)
on 2021-05-11 10:18:59 UTC
(
hide
)
Description:
Bug 27885: Populate biblionumbers parameter using biblionumbers array
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-05-11 10:18:59 UTC
Size:
1.83 KB
patch
obsolete
>From a1423ae849cb52a797e4a59dfaed562618b3be51 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 5 Mar 2021 17:32:28 +0000 >Subject: [PATCH] Bug 27885: Populate biblionumbers parameter using > biblionumbers array > >Currently we send $biblionumbers as the parameter, but this is just apassthrough form when a list of biblios is selected for placing a hold > >If passed a single biblionumber we push it into @biblionumbers and use that for building the biblio loop > >This patch uses @biblionumbers to avoid sending a blank variable in the URL > >To test: >1 - On the staff client click 'place hold' for an individual record >2 - Use the form to find a patron >3 - Note the url is: > http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers= >4 - Apply patch >5 - Repeat >6 - The url is now like: > http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=248 > (but with whatever biblionumber you chose) >7 - Perform a search and select multiple biblios and confirm you can place holds as before > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 9c83b617cf..d1c0440276 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -740,8 +740,8 @@ foreach my $biblionumber (@biblionumbers) { > } > > $template->param( biblioloop => \@biblioloop ); >-$template->param( biblionumbers => $biblionumbers ); > $template->param( no_reserves_allowed => $no_reserves_allowed ); >+$template->param( biblionumbers => join('/',@biblionumbers) ); > $template->param( exceeded_maxreserves => $exceeded_maxreserves ); > $template->param( exceeded_holds_per_record => $exceeded_holds_per_record ); > $template->param( subscriptionsnumber => CountSubscriptionFromBiblionumber($biblionumber)); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27885
:
117870
|
117871
|
120831
|
121425
|
123119
|
123120