Attachment 120848 Details for Bug 27445 – Bug 27445: OPAC header tweaks for non-JavaScript users

[patch] Bug 27445: OPAC header tweaks for non-JavaScript users

Bug-27445-OPAC-header-tweaks-for-non-JavaScript-us.patch (text/plain), 4.09 KB, created by Lucas Gass (lukeg) on 2021-05-11 16:15:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2021-05-11 16:15:58 UTC

Size: 4.09 KB

patch

obsolete

>From 64fcceaeec3759087de1c986369a6a43918f0232 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 15 Jan 2021 19:15:06 +0000
>Subject: [PATCH] Bug 27445: OPAC header tweaks for non-JavaScript users
>
>This patch makes some minor changes to the header menu in the OPAC
>visible only to users with JavaScript support.
>
>To test, apply the patch and rebuild the OPAC CSS
>(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
>
> - View the OPAC with JS disabled in your browser.
> - The "Cart" button should not be visible.
> - The "List," "Log in," and "Search history" links should be styled
> blue like other links.
> - Log in to the OPAC and confirm that the "Welcome <name>" link is also
> styled like other links.
> - Enable JavaScript and verify that the links appear and function just
> as they did before the patch.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 13 +++++++++++++
> koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 6 +++---
> 2 files changed, 16 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>index 7bab9bc9b6..0bdb49d70d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>@@ -20,6 +20,19 @@
> padding-left: 0;
> padding-right: 0;
> }
>+ .dropdown-toggle::after {
>+ border: 0;
>+ }
>+
>+ #listsmenu,
>+ #user-menu,
>+ .nav-item .login-link {
>+ color: $links;
>+
>+ &:hover {
>+ color: $links-hover;
>+ }
>+ }
> }
> 
> .js {
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>index b58703b8d0..5c10234c1e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
>@@ -27,7 +27,7 @@
> [% END %]
> <ul id="cart-list-nav" class="navbar-nav">
> [% IF ( Koha.Preference( 'opacbookbag' ) == 1 ) %]
>- <li class="nav-item">
>+ <li class="nav-item js-show">
> <a href="#" class="nav-link" title="Collect items you are interested in" id="cartmenulink" role="button">
> Cart 
> </a>
>@@ -36,7 +36,7 @@
> <li class="divider-vertical"></li>
> [% IF ( Koha.Preference( 'virtualshelves' ) == 1 ) %]
> <li class="nav-item dropdown">
>- <a href="#" title="Show lists" class="nav-link dropdown-toggle" id="listsmenu" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"
>+ <a href="/cgi-bin/koha/opac-shelves.pl" title="Show lists" class="nav-link dropdown-toggle" id="listsmenu" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"
> > Lists
> </a>
> <div aria-labelledby="listsmenu" role="menu" class="dropdown-menu">
>@@ -89,7 +89,7 @@
> <li class="nav-item dropdown">
> [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) %]
> [% IF ( loggedinusername ) %]
>- <a href="#" class="dropdown-toggle" id="user-menu" data-toggle="dropdown" role="button">
>+ <a href="/cgi-bin/koha/opac-user.pl" class="dropdown-toggle" id="user-menu" data-toggle="dropdown" role="button">
> 
> Welcome, [% INCLUDE 'patron-title.inc' patron = logged_in_user no_html = 1 %]
> </a>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27445: 115212 | 120848 | 122579