Attachment 120856 Details for Bug 26760 – Bug 26760: Escape URI parameters in redirect URI to paycollect.pl

[patch] Bug 26760: Escape URI parameters in redirect URI to paycollect.pl

Bug-26760-Escape-URI-parameters-in-redirect-URI-to.patch (text/plain), 1.71 KB, created by Julian Maurice on 2021-05-12 08:26:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2021-05-12 08:26:04 UTC

Size: 1.71 KB

patch

obsolete

>From fc46899ace957a2e8114cbdf4c07f705adbc1860 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Wed, 12 May 2021 10:24:30 +0200
>Subject: [PATCH] Bug 26760: Escape URI parameters in redirect URI to
> paycollect.pl
>
>Also remove useless '%.2f' formatting of amount and amountoutstanding
>---
> members/maninvoice.pl | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
>diff --git a/members/maninvoice.pl b/members/maninvoice.pl
>index 1062f74f83..3cf02ca7c4 100755
>--- a/members/maninvoice.pl
>+++ b/members/maninvoice.pl
>@@ -24,6 +24,7 @@
> 
> use Modern::Perl;
> use Try::Tiny;
>+use URI::Escape;
> 
> use C4::Auth;
> use C4::Output;
>@@ -172,13 +173,15 @@ if ($add) {
>             if ( $add eq 'save and pay' ) {
>                 my $url = sprintf(
>                     '/cgi-bin/koha/members/paycollect.pl?borrowernumber=%s&pay_individual=1&debit_type_code=%s&amount=%s&amountoutstanding=%s&description=%s&itemnumber=%s&accountlines_id=%s',
>-                    $borrowernumber,
>-                    $line->debit_type_code,
>-                    sprintf('%.2f', $line->amount),
>-                    sprintf('%.2f', $line->amountoutstanding),
>-                    $line->description,
>-                    $line->itemnumber,
>-                    $line->id
>+                    map { uri_escape_utf8($_) } (
>+                        $borrowernumber,
>+                        $line->debit_type_code,
>+                        $line->amount,
>+                        $line->amountoutstanding,
>+                        $line->description,
>+                        $line->itemnumber,
>+                        $line->id
>+                    )
>                 );
> 
>                 print $input->redirect($url);
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26760: 112093 | 112313 | 112351 | 120856 | 122577 | 122578