Attachment 120886 Details for Bug 28220 – Bug 28220: Add tests to import

[patch] Bug 28220: Add tests to import

Bug-28220-Add-tests-to-import.patch (text/plain), 4.92 KB, created by Martin Renvoize (ashimema) on 2021-05-12 15:57:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-05-12 15:57:35 UTC

Size: 4.92 KB

patch

obsolete

>From df8738a366f9a625c96a285d9bf19c57f0fd892a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 6 May 2021 10:13:55 +0200
>Subject: [PATCH] Bug 28220: Add tests to import
>
>failure expected, we need to add a transaction
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Koha/Patrons/Import.t | 112 ++++++++++++++++++++++++++-
> 1 file changed, 111 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Patrons/Import.t b/t/db_dependent/Koha/Patrons/Import.t
>index 522cf1ad79..884268baae 100755
>--- a/t/db_dependent/Koha/Patrons/Import.t
>+++ b/t/db_dependent/Koha/Patrons/Import.t
>@@ -18,8 +18,9 @@
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-use Test::More tests => 160;
>+use Test::More tests => 161;
> use Test::Warn;
>+use Test::Exception;
> use Encode qw( encode_utf8 );
> use utf8;
> 
>@@ -842,6 +843,115 @@ subtest 'test_format_dates' => sub {
>     is($missing_criticals_2[2]->{lineraw}, $borrowerline, 'Got the expected third lineraw from check_branch_code with bad dates');
> };
> 
>+subtest 'patron_attributes' => sub {
>+
>+    plan tests => 4;
>+
>+    t::lib::Mocks::mock_preference('ExtendedPatronAttributes', 1);
>+
>+    my $unique_attribute_type = $builder->build_object(
>+        {
>+            class => 'Koha::Patron::Attribute::Types',
>+            value => { unique_id=> 1, repeatable => 0 }
>+        }
>+    );
>+    my $repeatable_attribute_type = $builder->build_object(
>+        {
>+            class => 'Koha::Patron::Attribute::Types',
>+            value => { unique_id => 0, repeatable => 1 }
>+        }
>+    );
>+    my $normal_attribute_type = $builder->build_object(
>+        {
>+            class => 'Koha::Patron::Attribute::Types',
>+            value => { unique_id => 0, repeatable => 0 }
>+        }
>+    );
>+    my $non_existent_attribute_type = $builder->build_object(
>+        {
>+            class => 'Koha::Patron::Attribute::Types',
>+        }
>+    );
>+    my $non_existent_attribute_type_code = $non_existent_attribute_type->code;
>+    $non_existent_attribute_type->delete;
>+
>+    # attributes is { code => \@attributes }
>+    sub build_csv {
>+        my ($attributes) = @_;
>+
>+        my $csv_headers = 'cardnumber,surname,firstname,branchcode,categorycode,patron_attributes';
>+        my @attributes_str = map { my $code = $_; map {  sprintf "%s:%s", $code, $_ } @{ $attributes->{$code} } } keys %$attributes;
>+        my $attributes_str = join ',', @attributes_str;
>+        my $csv_line = sprintf '1042,John,D,MPL,PT,"%s"', $attributes_str;
>+        my $filename = make_csv( $temp_dir, $csv_headers, $csv_line );
>+        open( my $fh, "<:encoding(utf8)", $filename ) or die "cannot open $filename: $!";
>+        return $fh;
>+    }
>+
>+    { # Everything good, we create a patron with 3 attributes
>+        my $attributes = {
>+            $unique_attribute_type->code => ['my unique attribute 1'],
>+            $repeatable_attribute_type->code => [ 'my repeatable attribute 1', 'my repeatable attribute 2' ],
>+            $normal_attribute_type->code => ['my normal attribute 1'],
>+        };
>+        my $fh = build_csv({ %$attributes });
>+        my $result = $patrons_import->import_patrons({file => $fh});
>+
>+        is( $result->{imported}, 1 );
>+
>+        my $patron = Koha::Patrons->find({cardnumber => "1042"});
>+        compare_patron_attributes($patron->extended_attributes->unblessed, { %$attributes } );
>+        $patron->delete;
>+    }
>+
>+    {
>+        $builder->build_object(
>+            {
>+                class => 'Koha::Patron::Attributes',
>+                value => { code => $unique_attribute_type->code, attribute => 'unique' }
>+            }
>+        );
>+
>+        my $attributes = {
>+            $unique_attribute_type->code => ['unique'],
>+            $normal_attribute_type->code => ['my normal attribute 1']
>+        };
>+        my $fh = build_csv({ %$attributes });
>+
>+        throws_ok {
>+            $patrons_import->import_patrons({file => $fh});
>+        }
>+        'Koha::Exceptions::Patron::Attribute::UniqueIDConstraint';
>+
>+        my $patron = Koha::Patrons->find({cardnumber => "1042"});
>+        is( $patron, undef );
>+
>+    }
>+
>+};
>+
>+# got is { code => $code, attribute => $attribute }
>+# expected is { $code => \@attributes }
>+sub compare_patron_attributes {
>+    my ( $got, $expected ) = @_;
>+
>+    $got = [ map { { code => $_->{code}, attribute => $_->{attribute} } } @$got ];
>+    $expected = [
>+        map {
>+            my $code = $_;
>+            map { { code => $code, attribute => $_ } } @{ $expected->{$code} }
>+          } keys %$expected
>+    ];
>+    for my $v ( $got, $expected ) {
>+        $v = [
>+            sort {
>+                $a->{code} cmp $b->{code} || $a->{attribute} cmp $b->{attribute}
>+            } @$v
>+        ];
>+    }
>+    is_deeply($got, $expected);
>+}
>+
> # ###### Test utility ###########
> sub make_csv {
>     my ($temp_dir, @lines) = @_;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28220: 120549 | 120607 | 120608 | 120609 | 120610 | 120611 | 120612 | 120613 | 120614 | 120783 | 120784 | 120785 | 120786 | 120787 | 120788 | 120789 | 120790 | 120885 | 120886 | 120887 | 120888 | 120889 | 120890 | 120891 | 120892