Bugzilla – Attachment 120962 Details for
Bug 28187
rowGroup headings are getting their styles overriden
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28187: Exclude dtrg-group from row striping.
Bug-28187-Exclude-dtrg-group-from-row-striping.patch (text/plain), 1.84 KB, created by
Lucas Gass (lukeg)
on 2021-05-14 13:26:09 UTC
(
hide
)
Description:
Bug 28187: Exclude dtrg-group from row striping.
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2021-05-14 13:26:09 UTC
Size:
1.84 KB
patch
obsolete
>From 8b9d28b1c1f61f203f2d99e22ce365f539464fe7 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 14 May 2021 11:15:58 +0100 >Subject: [PATCH] Bug 28187: Exclude dtrg-group from row striping. > >The odd row lowlighting stripe effect added to datatales wasn't >accounting for classes introduced by the rowGroup plugin to denote >grouping header rows. This patch adds the required exclusion rule to >properly highlight rowGroup grouping rows. > >Test plan >1/ Enable POS >2/ Create a register and make some transactions. >3/ Have both debits and credits >4/ Have some older tranactions so you can look at the past_sales table. >5/ Apply patch and regenerate the staff CSS: >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) >6/ Look at the sales and past_sales table. >7/ Make sure each row header is the darker shade of gray (#e0e0e0) >7a/ You will need to have made some transactions with even and odd >numbers of items in the sale highlight the problem before applying the >patch >7b/ The rowGroup plugin is also used for the checkouts table and >this patch should also fix that case. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >index 01d25fd65f..b67f7f9268 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >@@ -331,7 +331,7 @@ caption { > > tbody { > tr { >- &:nth-child(odd) { >+ &:nth-child(odd):not(.dtrg-group) { > td { > border-right: 1px solid $table-border-color; > &:not(.bg-danger):not(.bg-warning):not(.bg-info):not(.bg-success):not(.bg-primary) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28187
:
119936
|
119951
|
119998
|
120956
|
120962
|
121104