Bugzilla – Attachment 120976 Details for
Bug 28302
Koha does not work with CGI::Compile 0.24
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28302: Forbid CGI::Compile 0.24
Bug-28302-Forbid-CGICompile-024.patch (text/plain), 1.66 KB, created by
Kyle M Hall (khall)
on 2021-05-14 15:12:33 UTC
(
hide
)
Description:
Bug 28302: Forbid CGI::Compile 0.24
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2021-05-14 15:12:33 UTC
Size:
1.66 KB
patch
obsolete
>From b3f64d373f2ce3e244f902b1d3f697cbcb1f694e Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 7 May 2021 17:57:58 +0200 >Subject: [PATCH] Bug 28302: Forbid CGI::Compile 0.24 >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >CGI::Compile 0.24 has a bug: >https://github.com/miyagawa/CGI-Compile/issues/25 > >It can cause weird bugs, like breaking the authority detail display >after trying to modify an authority. > >Steps to reproduce: >1. Install CGI::Compile 0.24 >2. Restart starman with only 1 worker >3. Go to the detail page of an authority (authorities/detail.pl) >4. Go to the edit page (Edit » Edit record) >5. Check starman logs, you should see "Subroutine build_tabs redefined >at [...]" >6. Click on cancel to go back to the detail page, which should now show >a "blank" authority. Now the only way to get the authority back is to >restart starman. > >Test plan: >1. Reproduce the bug >2. Install CGI::Compile 0.25 and restart starman >3. Make sure the bug is gone :) > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > cpanfile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/cpanfile b/cpanfile >index 287187f4da..2ef039431b 100644 >--- a/cpanfile >+++ b/cpanfile >@@ -7,7 +7,7 @@ requires 'Business::ISSN', '0.91'; > requires 'Bytes::Random::Secure', '0.28'; > requires 'CGI', '3.15'; > requires 'CGI::Carp', '1.29'; >-requires 'CGI::Compile', '0.17'; >+requires 'CGI::Compile', '>= 0.17, != 0.24'; > requires 'CGI::Emulate::PSGI', '0.20'; > requires 'CGI::Session', '4.2'; > requires 'CGI::Session::Serialize::yaml', '4.2'; >-- >2.24.3 (Apple Git-128)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28302
:
120704
|
120952
| 120976 |
121183
|
121243
|
121465