Bugzilla – Attachment 121184 Details for
Bug 28272
Definition files are missing additionalProperties: false
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28272: (QA follow-up) Add 'manager' to cashups definition
Bug-28272-QA-follow-up-Add-manager-to-cashups-defi.patch (text/plain), 1.52 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-05-19 15:58:02 UTC
(
hide
)
Description:
Bug 28272: (QA follow-up) Add 'manager' to cashups definition
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-05-19 15:58:02 UTC
Size:
1.52 KB
patch
obsolete
>From 8cb1b903888fd4237a1dadaec074094a3d5e01d4 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 19 May 2021 16:43:47 +0100 >Subject: [PATCH] Bug 28272: (QA follow-up) Add 'manager' to cashups definition > >The embeddable 'manager' relation field was missing from the >specification file and as such calls using this embed would result in a >500 error since we introduced 'additionalProperties: false'. > >Test plan >1/ Enable 'UseCashRegisters' >2/ Navigate to the register details page >3/ Inspect the network traffic and note a 500 error on the cashups api >call >4/ Apply the patch >5/ The 500 should have gone away and been replaced with an empty >resultset 200 page. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > api/v1/swagger/definitions/cashup.json | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/api/v1/swagger/definitions/cashup.json b/api/v1/swagger/definitions/cashup.json >index a4c5a426440..a2681d76327 100644 >--- a/api/v1/swagger/definitions/cashup.json >+++ b/api/v1/swagger/definitions/cashup.json >@@ -13,6 +13,13 @@ > "type": "integer", > "description": "Internal identifier for the manager the cashup was performed by" > }, >+ "manager": { >+ "type": [ >+ "object", >+ "null" >+ ], >+ "description": "The object representing the manager the cashup was performed by" >+ }, > "amount": { > "type": "number", > "description": "Account line amount" >-- >2.31.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28272
:
120630
|
120673
|
120690
|
120801
|
120812
|
120819
|
120833
|
121182
| 121184